Fix breakage of dhcp_lease_time utility.

This commit is contained in:
Simon Kelley
2019-08-14 21:52:50 +01:00
parent ab73a746a0
commit 225accd235
2 changed files with 5 additions and 1 deletions

View File

@@ -38,6 +38,10 @@ version 2.81
the DHCP server in subnets where the server (or relay) doesn't the DHCP server in subnets where the server (or relay) doesn't
have an interface on the network in that subnet. Many thanks to have an interface on the network in that subnet. Many thanks to
kamp.de for sponsoring this feature. kamp.de for sponsoring this feature.
Fix broken contrib/lease_tools/dhcp_lease_time.c. A packet
validation check got borked in commit 2b38e382 and release 2.80.
Thanks to Tomasz Szajner for spotting this.
version 2.80 version 2.80

View File

@@ -83,7 +83,7 @@ static unsigned char *option_find1(unsigned char *p, unsigned char *end, int opt
if (p >= end - 2) if (p >= end - 2)
return NULL; /* malformed packet */ return NULL; /* malformed packet */
opt_len = option_len(p); opt_len = option_len(p);
if (end - p >= (2 + opt_len)) if (end - p < (2 + opt_len))
return NULL; /* malformed packet */ return NULL; /* malformed packet */
if (*p == opt && opt_len >= minsize) if (*p == opt && opt_len >= minsize)
return p; return p;