From 382e38f4945316f11c814bcf9c625bf718856f82 Mon Sep 17 00:00:00 2001
From: Giovanni Bajo <rasky@develer.com>
Date: Tue, 24 Apr 2012 01:46:47 +0200
Subject: [PATCH] Specify the correct place where to canonicalize RR within
 RRset.

---
 src/dnssec.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/dnssec.c b/src/dnssec.c
index 369ba11..ad34557 100644
--- a/src/dnssec.c
+++ b/src/dnssec.c
@@ -169,9 +169,12 @@ static int validate_rrsig(struct dns_header *header, size_t pktlen,
       if (res == 1 && qtype == sigtype && qclass == sigclass)
         {
           ++rrsetidx;
-          assert(rrsetidx < countof(rrset));
-          /* TODO: here we should convert to lowercase domain names within 
-             RDATA. We can do it in place. */
+          if (rrsetidx == countof(rrset))
+            {
+              /* Internal buffer too small */
+              printf("internal buffer too small for this RRset\n");
+              return 0;
+            }
         }
       p += rdlen;
     }
@@ -205,6 +208,8 @@ static int validate_rrsig(struct dns_header *header, size_t pktlen,
       p = (unsigned char*)(rrset[i]);
       p += 8;
       GETSHORT(rdlen, p);
+      /* TODO: instead of a direct add_data(), we must call a RRtype-specific 
+         function, that extract and canonicalizes domain names within RDATA. */
       alg->add_data(p-2, rdlen+2);
     }
   alg->end_data();