Fix (benign) use of uninitialised data.

This commit is contained in:
Simon Kelley
2025-02-20 23:27:24 +00:00
parent 99f12e3541
commit 5487f6979e

View File

@@ -596,7 +596,11 @@ static int find_soa(struct dns_header *header, size_t qlen, char *name, int *sub
}
/* rest of RR */
if (!no_cache && !blockdata_expand(addr.rrblock.rrdata, addr.rrblock.datalen, (char *)p, 20))
if (!no_cache)
{
int secflag = 0;
if (!blockdata_expand(addr.rrblock.rrdata, addr.rrblock.datalen, (char *)p, 20))
{
blockdata_free(addr.rrblock.rrdata);
return 0;
@@ -604,10 +608,6 @@ static int find_soa(struct dns_header *header, size_t qlen, char *name, int *sub
addr.rrblock.datalen += 20;
if (!no_cache)
{
int secflag = 0;
#ifdef HAVE_DNSSEC
if (option_bool(OPT_DNSSEC_VALID) && daemon->rr_status[i + ntohs(header->ancount)] != 0)
{