Pi-Hole/dnsmasq
1
0
Fork 0
mirror of https://github.com/pi-hole/dnsmasq.git synced 2025-12-19 18:28:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bug in extract_name_no_compression.

Browse Source 
When the maxlen was exactly equal to the length of the string,
the function was returning 0 because the end-of-buffer check was
misplaced.
This commit is contained in:
Giovanni Bajo
2012-04-28 01:03:10 +02:00
committed by Simon Kelley
parent 32f82c62c8
commit 79333a2498
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/dnssec.c
View File

@@ -42,16 +42,16 @@ static int extract_name_no_compression(unsigned char *rr, int maxlen, char *buf)
if (*buf >= 'A' && *buf <= 'Z') if (*buf >= 'A' && *buf <= 'Z')
*buf += 'a' - 'A'; *buf += 'a' - 'A';
buf++; buf++;
} }
*buf++ = '.'; *buf++ = '.';
} }
// Remove trailing dot (if any) // Remove trailing dot (if any)
if (rr != start) if (rr != start)
*(--buf) = 0; *(--buf) = 0;
rr++;
if (rr == end) if (rr == end)
return 0; return 0;
return rr-start; // Trailing \0 in source data must be consumed
return rr-start+1;
} }
/* Check whether today/now is between date_start and date_end */ /* Check whether today/now is between date_start and date_end */