Pi-Hole/dnsmasq
1
0
Fork 0
mirror of https://github.com/pi-hole/dnsmasq.git synced 2025-12-19 10:18:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

rfc3315: fix incorrect logical '&&' warning

Browse Source 
rfc3315.c:1711:28: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
    if (!(addr_list->flags && ADDRLIST_DECLINED) ||
                           ^  ~~~~~~~~~~~~~~~~~

It's a flag bit so should be bitwise '&' operator

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
This commit is contained in:
Kevin Darbyshire-Bryant
2020-03-06 10:31:17 +00:00
committed by Simon Kelley
parent 70c50efd0d
commit b594e8defa
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/rfc3315.c
View File

@@ -1708,7 +1708,7 @@ static int config_valid(struct dhcp_config *config, struct dhcp_context *context
return 0; return 0;
for (addr_list = config->addr6; addr_list; addr_list = addr_list->next) for (addr_list = config->addr6; addr_list; addr_list = addr_list->next)
if (!(addr_list->flags && ADDRLIST_DECLINED) || if (!(addr_list->flags & ADDRLIST_DECLINED) ||
difftime(now, addr_list->decline_time) >= (float)DECLINE_BACKOFF) difftime(now, addr_list->decline_time) >= (float)DECLINE_BACKOFF)
{ {
addrpart = addr6part(&addr_list->addr.addr6); addrpart = addr6part(&addr_list->addr.addr6);