Drop the development tag - there is very little use in keeping it around, especially when there are file differences between master and dev on the other components. Instead, just update the nightly tag when the development branch has changes pushed to it.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
This commit is contained in:
Adam Warner
2025-10-06 20:55:53 +01:00
parent 6b685bb007
commit 0fd5c354e9
2 changed files with 6 additions and 7 deletions

View File

@@ -12,7 +12,7 @@ on:
env: env:
dockerhub: ${{ secrets.DOCKERHUB_NAMESPACE }}/pihole dockerhub: ${{ secrets.DOCKERHUB_NAMESPACE }}/pihole
ghcr: ghcr.io/${{ github.repository_owner }}/pihole ghcr: ghcr.io/${{ github.repository_owner }}/pihole
components_branch: ${{ github.event_name == 'schedule' && 'development' || 'master' }} components_branch: ${{ github.event_name == 'release' && 'master' || 'development' }}
jobs: jobs:
build: build:
@@ -62,7 +62,7 @@ jobs:
latest=${{ startsWith(github.ref, 'refs/tags/') }} latest=${{ startsWith(github.ref, 'refs/tags/') }}
tags: | tags: |
type=schedule,pattern=nightly type=schedule,pattern=nightly
type=ref,event=branch,enable=${{ github.event_name != 'schedule' }} type=ref,event=branch,enable=${{ github.event_name != 'schedule' }},pattern=nightly
type=ref,event=tag type=ref,event=tag
- -
@@ -148,7 +148,7 @@ jobs:
- name: Docker meta - name: Docker meta
id: meta id: meta
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 #v5.0.0 uses: docker/metadata-action@c1e51972afc2121e065aed6d45c65596fe445f3f #v5.8.0
with: with:
github-token: ${{ secrets.GITHUB_TOKEN }} github-token: ${{ secrets.GITHUB_TOKEN }}
images: | images: |
@@ -158,7 +158,7 @@ jobs:
latest=${{ startsWith(github.ref, 'refs/tags/') }} latest=${{ startsWith(github.ref, 'refs/tags/') }}
tags: | tags: |
type=schedule,pattern=nightly type=schedule,pattern=nightly
type=ref,event=branch,enable=${{ github.event_name != 'schedule' }} type=ref,event=branch,enable=${{ github.event_name != 'schedule' }},pattern=nightly
type=ref,event=tag type=ref,event=tag
- -

View File

@@ -200,12 +200,11 @@ Release notes will always contain full details of changes in the container, incl
| tag | description | tag | description
|---------------------|--------------------------------------------------------------------------------------------------------------------------------------------| |---------------------|--------------------------------------------------------------------------------------------------------------------------------------------|
| `latest` | Always latest release | | `latest` | Always the latest release |
| `2022.04.0` | Date-based release | | `2022.04.0` | Date-based release |
| `2022.04.1` | Second release in a given month | | `2022.04.1` | Second release in a given month |
| `development` | Similar to `latest`, but for the development branch (pushed occasionally) |
| `*beta` | Early beta releases of upcoming versions - here be dragons | | `*beta` | Early beta releases of upcoming versions - here be dragons |
| `nightly` | Like `development` but pushed every night and pulls from the latest `development` branches of the core Pi-hole components (Pi-hole, web, FTL) | | `nightly` | Built and pushed whenever there are changes on the `development` branch and additionally produced by the scheduled nightly job. These are the most experimental development images and may change frequently |
## Upgrading, Persistence, and Customizations ## Upgrading, Persistence, and Customizations