Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2026-08-23 06:39:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix CI: merge duplicate .card selectors left by box/panel conversion

Browse Source 
Bootstrap 3 had two separate legacy container concepts - .box and
.panel - that both map onto Bootstrap 5's single .card. The box/panel
to card conversion renamed each occurrence independently, so wherever
a theme file already styled one of them under the other's name (or a
pre-existing .card rule for the advanced-settings cards collided with
a freshly renamed .box/.panel), the result was two separate rule
blocks for the same selector - flagged by CodeFactor's
no-duplicate-selectors check.

Merged each pair into a single rule, keeping whichever value wins the
cascade in the current (duplicated) state so the resolved styles are
unchanged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
This commit is contained in:
Adam Warner
2026-07-06 18:31:37 +01:00
co-authored by Claude Sonnet 5
parent 37e3813a21
commit 19f900c898
2 changed files with 6 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
style/pi-hole.css
+4 -8
View File
@@ -524,8 +524,11 @@ tfoot.add-new-item > tr > th {
}
.card {
border-radius: 8px;
border-radius: 6px;
overflow: hidden;
margin: 0 0 1em;
padding: 0.5em;
border: 1px solid color-mix(currentColor 15%, transparent);
}
.small-box {
@@ -1636,13 +1639,6 @@ border-top=1px + padding-top=6px + padding-bottom=6px + border-bottom=1px
margin: 0 0 1em;
}
.card {
border-radius: 6px;
margin: 0 0 1em;
padding: 0.5em;
border: 1px solid color-mix(currentColor 15%, transparent);
}
/* Used in query log page */
td.dnssec {
padding-inline-start: 2.25em !important;
style/themes/default-darker.css
+2 -12
View File
@@ -1911,14 +1911,6 @@ button.list-group-item-danger.active:hover {
background-color: rgb(135, 54, 53);
border-color: rgb(133, 53, 52);
}
.card {
background-color: rgb(24, 26, 27);
border-color: transparent;
box-shadow: rgba(0, 0, 0, 0.05) 0 1px 1px;
}
.card-header {
border-bottom-color: transparent;
}
.card-header > .dropdown .dropdown-toggle {
color: inherit;
}
@@ -1932,10 +1924,6 @@ button.list-group-item-danger.active:hover {
.card-title > small > a {
color: inherit;
}
.card-footer {
background-color: rgb(30, 32, 33);
border-top-color: rgb(58, 62, 65);
}
.card > .list-group:first-child .list-group-item:first-child,
.card > .panel-collapse > .list-group:first-child .list-group-item:first-child {
border-top-color: currentcolor;
@@ -2916,6 +2904,7 @@ a:focus {
.card {
background-color: rgb(24, 26, 27);
background-image: none;
border-color: transparent;
border-top-color: rgb(59, 64, 66);
box-shadow: rgba(0, 0, 0, 0.1) 0 1px 1px;
}
@@ -3058,6 +3047,7 @@ a:focus {
background-image: none;
}
.card-header {
border-bottom-color: transparent;
color: rgb(189, 183, 175);
}
.card-header.with-border {