Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2025-12-24 04:38:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

group-domains: fix uncaught TypeError due to invalid URLs

Browse Source 
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
XhmikosR
2025-04-03 08:02:16 +03:00
parent fd5322c0df
commit 2ea1a6bf0b
1 changed files with 25 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
scripts/js/groups-domains.js
View File

@@ -63,23 +63,34 @@ function showSuggestDomains(value) {
var newDomainEl = $("#new_domain");
var suggestDomainEl = $("#suggest_domains");
var parts = new URL(value).hostname.split(".");
var table = $("<table>");
try {
var parts = new URL(value).hostname.split(".");
var table = $("<table>");
for (var i = 0; i < parts.length - 1; ++i) {
var hostname = parts.slice(i).join(".");
for (var i = 0; i < parts.length - 1; ++i) {
var hostname = parts.slice(i).join(".");
table.append(
$("<tr>")
.append($('<td class="text-nowrap text-right">').text(i === 0 ? "Did you mean" : "or"))
.append($("<td>").append(createButton(hostname)))
);
table.append(
$("<tr>")
.append($('<td class="text-nowrap text-right">').text(i === 0 ? "Did you mean" : "or"))
.append($("<td>").append(createButton(hostname)))
);
}
suggestDomainEl.slideUp("fast", function () {
suggestDomainEl.html(table);
suggestDomainEl.slideDown("fast");
});
} catch (error) {
const { message } = error;
const isValidUrlError =
error instanceof TypeError &&
(message.includes("Invalid URL") || message.includes("is not a valid URL"));
if (!isValidUrlError) {
throw error;
}
}
suggestDomainEl.slideUp("fast", function () {
suggestDomainEl.html(table);
suggestDomainEl.slideDown("fast");
});
}
function hideSuggestDomains() {