Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2025-12-24 12:48:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use idstring in messages when it's not necessary

Browse Source 
Signed-off-by: Christian König <ckoenig@posteo.de>
This commit is contained in:
Christian König
2023-01-20 15:03:14 +01:00
parent acac90f79d
commit 4473955291
6 changed files with 72 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
scripts/pi-hole/js/groups-adlists.js
View File

@@ -465,7 +465,7 @@ function delItems(ids) {
utils.disableAll();
var idstring = ids.join(", ");
utils.showAlert("info", "", "Deleting Adlist with ID: " + idstring, "...");
utils.showAlert("info", "", "Deleting adlist(s) ...", "<ul>" + address + "</ul>");
$.ajax({
url: "scripts/pi-hole/php/groups.php",
@@ -479,7 +479,7 @@ function delItems(ids) {
utils.showAlert(
"success",
"far fa-trash-alt",
"Successfully deleted adlists: " + idstring,
"Successfully deleted adlist(s): ",
"<ul>" + address + "</ul>"
);
for (var id in ids) {
@@ -488,7 +488,12 @@ function delItems(ids) {
}
}
} else {
utils.showAlert("error", "", "Error while deleting adlists: " + idstring, response.message);
utils.showAlert(
"error",
"",
"Error while deleting adlist(s): " + idstring,
response.message
);
}
// Clear selection after deletion
@@ -497,7 +502,12 @@ function delItems(ids) {
})
.fail(function (jqXHR, exception) {
utils.enableAll();
utils.showAlert("error", "", "Error while deleting adlists: " + idstring, jqXHR.responseText);
utils.showAlert(
"error",
"",
"Error while deleting adlist(s): " + idstring,
jqXHR.responseText
);
console.log(exception); // eslint-disable-line no-console
});
}