From 5036b1df1322ecbdcecc00f17d195ac2a66c7dca Mon Sep 17 00:00:00 2001
From: XhmikosR <xhmikosr@gmail.com>
Date: Sun, 23 Mar 2025 19:18:21 +0200
Subject: [PATCH] Navigation: switch to a real button

Better for accessibility

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
---
 scripts/lua/header_authenticated.lp | 5 ++---
 style/pi-hole.css                   | 3 ++-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/lua/header_authenticated.lp b/scripts/lua/header_authenticated.lp
index ff0e9334..869de61e 100644
--- a/scripts/lua/header_authenticated.lp
+++ b/scripts/lua/header_authenticated.lp
@@ -48,11 +48,10 @@ mg.include('header.lp','r')
         <!-- Header Navbar: style can be found in header.less -->
         <nav class="navbar navbar-static-top">
             <!-- Sidebar toggle button-->
-            <a href="#" class="sidebar-toggle-svg" data-toggle="push-menu" role="button">
+            <button class="sidebar-toggle-svg" data-toggle="push-menu" aria-label="Toggle Navigation">
                 <i aria-hidden="true" class="fa fa-angle-double-left"></i>
-                <span class="sr-only">Toggle navigation</span>
                 <span class="warning-count hidden" id="top-warning-count"></span>
-            </a>
+            </button>
             <div class="navbar-custom-menu">
                 <ul class="nav navbar-nav">
                     <li<? if string.len(hostname) == 0 then ?> class="hidden"<? end ?>>
diff --git a/style/pi-hole.css b/style/pi-hole.css
index ce336ce8..46e05d4c 100644
--- a/style/pi-hole.css
+++ b/style/pi-hole.css
@@ -414,7 +414,8 @@ tfoot.add-new-item > tr > th {
   position: relative;
   color: #fff;
   float: left;
-  background: none;
+  background-color: transparent;
+  border: none;
   padding: 15px;
   width: 50px;
   text-align: center;