Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2025-12-24 04:38:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always inform about any invalid domains on a list using exclamation-triangle and bold-red text in the invalid domains column

Browse Source 
Signed-off-by: DL6ER <dl6er@dl6er.de>
This commit is contained in:
DL6ER
2020-12-28 10:56:11 +01:00
parent 9b821dd481
commit 9be0c61050
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
scripts/pi-hole/js/groups-adlists.js
View File

@@ -67,6 +67,11 @@ function format(data) {
}
}
var invalidStyle =
data.invalid_domains !== null && numbers === true
? ' style="color:red; font-weight:bold;"'
: "";
// Compile extra info for displaying
return (
"<table>" +
@@ -89,7 +94,10 @@ function format(data) {
: "N/A") +
'</td></tr><tr class="dataTables-child"><td>Number of valid domains on this list:&nbsp;&nbsp;</td><td>' +
(data.number !== null && numbers === true ? data.number : "N/A") +
'</td></tr><tr class="dataTables-child"><td>Number of invalid domains on this list:&nbsp;&nbsp;</td><td>' +
'</td></tr><tr class="dataTables-child"' +
invalidStyle +
"><td>Number of invalid domains on this list:&nbsp;&nbsp;</td>" +
"<td>" +
(data.invalid_domains !== null && numbers === true ? data.invalid_domains : "N/A") +
'</td></tr><tr class="dataTables-child"><td>Database ID of this list:</td><td>' +
data.id +
@@ -131,7 +139,6 @@ function initTable() {
statusCode = parseInt(data.status, 10);
}
$("td:eq(0)", row).addClass("list-status-" + statusCode);
switch (statusCode) {
default:
case 0:
@@ -151,7 +158,14 @@ function initTable() {
break;
}
$("td:eq(0)", row).html("<i class='fa " + statusIcon + "'></i>");
// Always overwrite icon with red exclamation-triangle when there are invalid lines in a list
var extra = "";
if (data.invalid_domains !== null && data.invalid_domains > 0) {
extra = "<i class='fa fa-exclamation-triangle list-status-3'></i>";
}
$("td:eq(0)", row).addClass("list-status-" + statusCode);
$("td:eq(0)", row).html("<i class='fa " + statusIcon + "'></i>" + extra);
$("td:eq(1)", row).html(
'<a id="address_' +