From c07b710d07bf9fb2eecd1f9c3e80b7ca252e0a97 Mon Sep 17 00:00:00 2001 From: yubiuser Date: Sun, 20 Dec 2020 20:26:37 +0100 Subject: [PATCH] Validate target domain for CNAME records Signed-off-by: yubiuser --- scripts/pi-hole/php/func.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/pi-hole/php/func.php b/scripts/pi-hole/php/func.php index 105b4853..ef817b54 100644 --- a/scripts/pi-hole/php/func.php +++ b/scripts/pi-hole/php/func.php @@ -302,6 +302,9 @@ function addCustomCNAMEEntry($domain="", $target="", $json=true) if (empty($target)) return returnError("Target must be set", $json); + if (!is_valid_domain_name($target)) + return returnError("Trget must be valid", $json); + // Check if each submitted domain is valid $domains = array_map('trim', explode(",", $domain)); foreach ($domains as $d) {