Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2025-12-24 12:48:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings-system : Avoid division by zero in DNS metrics

Browse Source 
Don't attempt to calculate a percentage if there are no replies yet

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
This commit is contained in:
Rob Gill
2025-06-26 09:09:56 +10:00
parent 471e53b6cf
commit ce991b2434
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/js/settings-system.js
View File

@@ -134,7 +134,7 @@ function setMetrics(data, prefix) {
cacheData[val.name] = val.count; cacheData[val.name] = val.count;
} else if (typeof val === "object") { } else if (typeof val === "object") {
setMetrics(val, prefix + key + "-"); setMetrics(val, prefix + key + "-");
} else if (prefix === "sysinfo-dns-replies-") { } else if (prefix === "sysinfo-dns-replies-" && data.sum !== 0) {
// Compute and display percentage of DNS replies in addition to the absolute value // Compute and display percentage of DNS replies in addition to the absolute value
const lval = val.toLocaleString(); const lval = val.toLocaleString();
const percent = (100 * val) / data.sum; const percent = (100 * val) / data.sum;