From eb140af01a9a3322cedfe9c8ca90b194fdcadf07 Mon Sep 17 00:00:00 2001
From: sharkboots75 <sharkboots75@gmail.com>
Date: Thu, 17 Apr 2025 06:33:49 +1000
Subject: [PATCH 1/2] Make DNSSEC icon conditional in Queries Log

Avoid emitting the DNSSEC icon in Domain column if DNSSEC is not being used/tracked

Signed-off-by: sharkboots75 <sharkboots75@gmail.com>
---
 scripts/js/queries.js | 34 +++++++++++++++++++++++++---------
 style/pi-hole.css     | 10 ++++++++++
 2 files changed, 35 insertions(+), 9 deletions(-)

diff --git a/scripts/js/queries.js b/scripts/js/queries.js
index c0a3c2ba..94a814bb 100644
--- a/scripts/js/queries.js
+++ b/scripts/js/queries.js
@@ -28,6 +28,17 @@ const filters = [
   "reply",
   "dnssec",
 ];
+var doDNSSEC = false;
+
+// Check if pihole is validiting DNSSEC
+function getDnssecConfig() {
+  $.getJSON(
+    document.body.dataset.apiurl + "/config/dns/dnssec",
+    function(data) {
+      doDNSSEC = data.config.dns.dnssec;
+    }
+  );
+}
 
 function initDateRangePicker() {
   $("#querytime").daterangepicker(
@@ -480,6 +491,9 @@ function liveUpdate() {
 }
 
 $(() => {
+  // Do we want to show DNSSEC icons?
+  getDnssecConfig();
+
   // Do we want to filter queries?
   const GETDict = utils.parseQueryString();
 
@@ -565,7 +579,6 @@ $(() => {
     },
     rowCallback(row, data) {
       const querystatus = parseQueryStatus(data);
-      const dnssec = parseDNSSEC(data);
 
       if (querystatus.icon !== false) {
         $("td:eq(1)", row).html(
@@ -589,14 +602,17 @@ $(() => {
 
       // Prefix colored DNSSEC icon to domain text
       let dnssecIcon = "";
-      dnssecIcon =
-        '<i class="mr-2 fa fa-fw ' +
-        dnssec.icon +
-        " " +
-        dnssec.color +
-        '" title="DNSSEC: ' +
-        dnssec.text +
-        '"></i>';
+      if (doDNSSEC === true) {
+        const dnssec = parseDNSSEC(data);
+        dnssecIcon =
+          '<i class="mr-2 fa fa-fw ' +
+          dnssec.icon +
+          " " +
+          dnssec.color +
+          '" title="DNSSEC: ' +
+          dnssec.text +
+          '"></i>';
+      }
 
       // Escape HTML in domain
       domain = dnssecIcon + utils.escapeHtml(domain);
diff --git a/style/pi-hole.css b/style/pi-hole.css
index fc51792e..1ab96976 100644
--- a/style/pi-hole.css
+++ b/style/pi-hole.css
@@ -1609,3 +1609,13 @@ textarea.field-sizing-content {
   opacity: 0;
   transition: opacity 200ms ease-in-out;
 }
+
+/* Used in query log page */
+td.dnssec {
+  padding-inline-start: 2.25em !important;
+  text-indent: -1.25em;
+}
+td.dnssec i {
+  text-indent: 0;
+  margin-left: -0.5rem;
+}

From fc01fb030e33205adc56dfbd9b4fc6d6a9570ee3 Mon Sep 17 00:00:00 2001
From: yubiuser <github@yubiuser.dev>
Date: Fri, 27 Jun 2025 12:35:19 +0200
Subject: [PATCH 2/2] Fix tests

Signed-off-by: yubiuser <github@yubiuser.dev>
---
 scripts/js/queries.js | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/scripts/js/queries.js b/scripts/js/queries.js
index 94a814bb..9fd26f63 100644
--- a/scripts/js/queries.js
+++ b/scripts/js/queries.js
@@ -28,16 +28,13 @@ const filters = [
   "reply",
   "dnssec",
 ];
-var doDNSSEC = false;
+let doDNSSEC = false;
 
 // Check if pihole is validiting DNSSEC
 function getDnssecConfig() {
-  $.getJSON(
-    document.body.dataset.apiurl + "/config/dns/dnssec",
-    function(data) {
-      doDNSSEC = data.config.dns.dnssec;
-    }
-  );
+  $.getJSON(document.body.dataset.apiurl + "/config/dns/dnssec", data => {
+    doDNSSEC = data.config.dns.dnssec;
+  });
 }
 
 function initDateRangePicker() {