Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2025-12-24 04:38:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify code by removing duplication of array

Browse Source 
Signed-off-by: DL6ER <dl6er@dl6er.de>
This commit is contained in:
DL6ER
2022-02-27 21:09:26 +01:00
parent 0dd9b304ac
commit e614da5946
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
scripts/pi-hole/js/messages.js
View File

@@ -275,14 +275,9 @@ function delMsg(ids) {
// Check input validity
if (!Array.isArray(ids)) return;
// Finding out which <tr> should be deleted, based on ID
var trs = [];
// Exploit prevention: Return early for non-numeric IDs
for (var id in ids) {
if (Object.hasOwnProperty.call(ids, id)) {
// Exploit prevention: Return early for non-numeric IDs
if (typeof ids[id] !== "number") return;
trs.push(ids[id]);
}
if (Object.hasOwnProperty.call(ids, id) && typeof ids[id] !== "number") return;
}
utils.disableAll();
@@ -304,9 +299,9 @@ function delMsg(ids) {
"Successfully deleted messages: " + idstring,
""
);
for (var tr in trs) {
if (Object.hasOwnProperty.call(trs, tr)) {
table.row(tr).remove().draw(false).ajax.reload(null, false);
for (var id in ids) {
if (Object.hasOwnProperty.call(ids, id)) {
table.row(id).remove().draw(false).ajax.reload(null, false);
}
}
} else {