diff --git a/custom_dns.php b/custom_dns.php
index d4477c20..5e594d7c 100644
--- a/custom_dns.php
+++ b/custom_dns.php
@@ -30,7 +30,7 @@
- Adding the custom DNS entry...
+ Updating the custom DNS entries...
@@ -62,13 +62,6 @@
Action |
-
-
- | Domain |
- IP |
- Action |
-
-
diff --git a/scripts/pi-hole/js/customdns.js b/scripts/pi-hole/js/customdns.js
index e30c6f4f..4ff50223 100644
--- a/scripts/pi-hole/js/customdns.js
+++ b/scripts/pi-hole/js/customdns.js
@@ -1,5 +1,26 @@
var table;
+function showAlert(type, message)
+{
+ var alertElement = null;
+ var messageElement = null;
+
+ switch (type)
+ {
+ case 'info': alertElement = $('#alInfo'); break;
+ case 'success': alertElement = $('#alSuccess'); break;
+ case 'warning': alertElement = $('#alWarning'); messageElement = $('#warn'); break;
+ case 'error': alertElement = $('#alFailure'); messageElement = $('#err'); break;
+ default: return;
+ }
+
+ if (messageElement != null)
+ messageElement.html(message);
+
+ alertElement.fadeIn(200);
+ alertElement.delay(8000).fadeOut(2000);
+}
+
$(document).ready(function() {
$('#btnAdd').on('click', addCustomDNS);
@@ -25,19 +46,22 @@ function addCustomDNS()
var ip = $('#ip').val();
var domain = $('#domain').val();
+ showAlert('info');
$.ajax({
url: "scripts/pi-hole/php/customdns.php",
method: "post",
dataType: 'json',
data: {"action":"add", "ip" : ip, "domain": domain},
success: function(response) {
- if (response.success)
+ if (response.success) {
+ showAlert('success');
table.ajax.reload();
+ }
else
- alert(response.message);
+ showAlert('error', response.message);
},
error: function(jqXHR, exception) {
- alert("Error while adding this custom DNS entry")
+ showAlert('error', "Error while adding this custom DNS entry");
}
});
}
@@ -47,19 +71,22 @@ function deleteCustomDNS()
var ip = $(this).attr("data-ip");
var domain = $(this).attr("data-domain");
+ showAlert('info');
$.ajax({
url: "scripts/pi-hole/php/customdns.php",
method: "post",
dataType: 'json',
data: {"action":"delete", "domain": domain, "ip": ip},
success: function(response) {
- if (response.success)
+ if (response.success) {
+ showAlert('success');
table.ajax.reload();
+ }
else
- alert(response.message);
+ showAlert('error', response.message);
},
error: function(jqXHR, exception) {
- alert("Error while deleting this custom DNS entry");
+ showAlert('error', "Error while deleting this custom DNS entry");
console.log(exception);
}
});
diff --git a/scripts/pi-hole/php/customdns.php b/scripts/pi-hole/php/customdns.php
index 8c0d0bb1..982981e2 100644
--- a/scripts/pi-hole/php/customdns.php
+++ b/scripts/pi-hole/php/customdns.php
@@ -82,7 +82,6 @@
return errorJsonResponse("This domain already has a custom DNS entry for an IPv" . $ipType);
exec("sudo pihole -a addcustomdns ".$ip." ".$domain);
- exec("sudo pihole -a restartdns");
return successJsonResponse();
}
@@ -119,7 +118,6 @@
return errorJsonResponse("This domain/ip association does not exist");
exec("sudo pihole -a removecustomdns ".$ip." ".$domain);
- exec("sudo pihole -a restartdns");
return successJsonResponse();
}