diff --git a/scripts/pi-hole/js/settings-advanced.js b/scripts/pi-hole/js/settings-advanced.js index 04970aed..7e062f27 100644 --- a/scripts/pi-hole/js/settings-advanced.js +++ b/scripts/pi-hole/js/settings-advanced.js @@ -272,7 +272,7 @@ function generateRow(topic, key, value) { // else: we have a setting we can display var box = '
' + - '
' + + '
' + '

' + - '
' + - '
' + - '

' + - topic.description + - " (" + - topic.name + - ")" + - "

" + - "
" + - '
' + - '
' + - '
' + - "
" + - "
" + - "
" + - "

" - ); + + $("#advanced-settings-tabs").append(` +
+ +
+
+
+
+ `); + + // Dynamically create the settings menu + $("#advanced-settings-menu ul").append(` +
  • + ${topic.description} +
  • + `); }); + + // Dynamically fill the tabs with config topics Object.keys(data.config).forEach(function (topic) { var value = data.config[topic]; generateRow(topic, topic, value, data); }); $("#advanced-overlay").hide(); + // Select the first tab and show the content + $("#advanced-settings-menu ul li:first-child").addClass("active"); + $("#advanced-settings-tabs > div:first-child").addClass("active in"); + $("button[id='save']").on("click", function () { saveSettings(); }); diff --git a/settings-all.lp b/settings-all.lp index f7253619..40c49f6b 100644 --- a/settings-all.lp +++ b/settings-all.lp @@ -14,11 +14,21 @@ PageTitle = "All Settings" mg.include('scripts/pi-hole/lua/settings_header.lp','r') ?>
    -
    -
    + +
    + +
    + +
    + +
    + +
    diff --git a/style/pi-hole.css b/style/pi-hole.css index 748375d6..2b4bdb08 100644 --- a/style/pi-hole.css +++ b/style/pi-hole.css @@ -1150,6 +1150,8 @@ table.dataTable tbody > tr > .selected { .settings-container > .box { margin: 0; width: calc((100% - (var(--gap) * (var(--columns) - 1))) / var(--columns)); + border: none; + box-shadow: 0 0 1px rgba(0, 0, 0, 0.1); } .settings-box .control-label small { font-weight: normal;