Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2025-12-24 04:38:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use proper Object methods (#3441)

Browse Source
This commit is contained in:
Adam Warner
2025-05-19 18:26:44 +01:00
committed by GitHub
parent 064154f0e6 44226e1bec
commit f683631afd
11 changed files with 85 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/js/settings-advanced.js
View File

@@ -264,8 +264,7 @@ function valueDetails(key, value) {
function generateRow(topic, key, value) {
// If the value is an object, we need to recurse
if (!("description" in value)) {
for (const subkey of Object.keys(value)) {
const subvalue = value[subkey];
for (const [subkey, subvalue] of Object.entries(value)) {
generateRow(topic, key + "." + subkey, subvalue);
}
@@ -303,9 +302,7 @@ function createDynamicConfigTabs() {
})
.done(data => {
// Create the tabs for the advanced dynamic config topics
for (const n of Object.keys(data.topics)) {
const topic = data.topics[n];
for (const topic of Object.values(data.topics)) {
$("#advanced-settings-tabs").append(`
<div id="advanced-content-${topic.name}" role="tabpanel" class="tab-pane fade">
<h3 class="page-header">${topic.description} (<code>${topic.name}</code>)</h3>
@@ -324,8 +321,7 @@ function createDynamicConfigTabs() {
}
// Dynamically fill the tabs with config topics
for (const topic of Object.keys(data.config)) {
const value = data.config[topic];
for (const [topic, value] of Object.entries(data.config)) {
generateRow(topic, topic, value);
}