Commit Graph

1595 Commits

Author SHA1 Message Date
DL6ER
012116a58d Merge pull request #1672 from pi-hole/fix/groups_backend
Bugfix allowing to effectively set empty domain/client/adlist groupsets
2021-01-13 21:28:20 +01:00
Dan Schaper
2976254bbc unicorn/no-lonely-if
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2021-01-02 20:53:20 -08:00
Dan Schaper
e763993574 unicorn/prefer-dom-node-append
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2021-01-02 20:33:14 -08:00
Dan Schaper
3bd702563c Date.now() fixes
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2021-01-02 20:33:14 -08:00
buchwasa
650ae0bf56 Use new style constructors
Signed-off-by: buchwasa <17461354+buchwasa@users.noreply.github.com>
2020-12-31 15:00:21 -05:00
DL6ER
9b19104ae6 Merge pull request #1654 from buchwasa/phpstan-fixes
Fixes in func.php from phpstan
2020-12-31 11:59:23 +01:00
DL6ER
ba1ac8621f Use empty array for foreach() when no group is to be set, always commit when editing domains, and report any errors while commiting.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-12-28 07:57:58 +01:00
Fabian Preuß
54dfc54a61 Fix sorting by replies in query log
Signed-off-by: Fabian Preuß <preuss_fabian@gmx.de>
2020-12-27 04:45:24 +01:00
Adam Warner
f7733f430e Merge pull request #1664 from pi-hole/fix/transactions
Fix transactions in groups.php
2020-12-23 22:34:04 +00:00
DL6ER
8d73511005 Merge pull request #1665 from pi-hole/fix/escape-all-the-things
Prevent malformed DNS queries executing JS on querylog/long term query pages
2020-12-23 20:47:36 +01:00
Adam Warner
a28f4e4f18 Prevent malformed DNS queries executing JS on querylog/long term query log
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-12-23 18:11:14 +00:00
DL6ER
564a4838ae Fix transactions in groups.php
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-12-23 15:21:57 +01:00
yubiuser
42e7915b53 Fix typo
Signed-off-by: yubiuser <ckoenig@posteo.de>
2020-12-20 20:35:21 +01:00
yubiuser
c07b710d07 Validate target domain for CNAME records
Signed-off-by: yubiuser <ckoenig@posteo.de>
2020-12-20 20:26:37 +01:00
buchwasa
98e6a45242 Fixes in func.php from phpstan
Signed-off-by: buchwasa <17461354+buchwasa@users.noreply.github.com>
2020-12-10 16:51:42 -05:00
DL6ER
ad5679ae70 Merge pull request #1619 from notriddle/master
Switch from fontawesome webfonts to SVG + JS
2020-12-10 22:24:11 +01:00
DL6ER
835f12ddec Merge pull request #1594 from yubiuser/tweak/colors
Change color of blocked queries in dashboard piechart forward destination to red
2020-12-10 22:08:35 +01:00
DL6ER
6ade8df31f Merge pull request #1646 from dnhp/bf-dnhp-1643
Fix issue 1643 - Show status of retried DNS queries in query log correctly
2020-12-10 22:06:36 +01:00
Aidan Woods
85c7a3b437 Use hash_equals when comparing to pwhash from cookie
This should prevent a timing attack against this parameter to
disclose the stored passsword hash.

Signed-off-by: Aidan Woods <aidantwoods@gmail.com>
2020-12-06 13:26:02 +00:00
dnhp
ef6a740370 Fix issue 1643 - quote numbers in switch case
Signed-off-by: dnhp <34394848+dnhp@users.noreply.github.com>
2020-12-01 12:04:16 +00:00
Adam Warner
68351a3a91 Merge pull request #1634 from pi-hole/new/unlink_DHCP_lease
Add button to remove dynamic DHCP leases
2020-11-28 16:32:37 +00:00
Adam Warner
483f5037db Merge pull request #1625 from pi-hole/tweak/replace_domains
Add new replace_domain action to allow adding domain(s) exclusively to a specific list
2020-11-28 16:25:38 +00:00
Adam Warner
99feecdf4d Merge pull request #1626 from pi-hole/fix/no_empty_names
Ensure empty clients/groups/adlists/audits cannot be added
2020-11-28 16:13:29 +00:00
DL6ER
6e0e1bbb41 Add button to remove dynamic DHCP leases. They are immediately removed both from FTL and the dhcp.leases file (FTL takes care of updating the file!) WITHOUT the need for a restart of the DHCP/DNS resolver.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-23 13:35:40 +01:00
DL6ER
1ea21911cf Merge pull request #1630 from pi-hole/new/mesage_dnsmasq_config_errors
Print fatal dnsmasq errors
2020-11-18 00:11:32 +01:00
DL6ER
5e808765e3 Print fatal dnsmasq errors
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-17 22:41:00 +01:00
DL6ER
4ee491115a Show upstream destination a query was sent to in the Query Log (both standard and long-term)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-13 01:01:49 +01:00
DL6ER
c8b85b8596 Use INSERT OR IGNORE instead of REPLACE
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-10 21:26:01 +01:00
DL6ER
0de0edcc9b Merge branch 'devel' into tweak/replace_domains 2020-11-09 22:28:13 +01:00
DL6ER
a3b24e08aa Reduce code-duplication by moving the addFromQueryLog() function into utils.js. This also fixes non-visible modals on the long-term query log page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-09 21:33:09 +01:00
DL6ER
ad43e5a8dc Add missing space and extend error hiding timeout from 4 to 10 seconds.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-09 21:21:30 +01:00
DL6ER
4557846858 Use JOIN instead of nested SELECT
Signed-off-by: DL6ER <dl6er@dl6er.de>
Co-authored-by: Adam Warner <me@adamwarner.co.uk>
2020-11-09 21:17:26 +01:00
DL6ER
f5a39ce1e4 Check if replacing the domain messes with existing special groups settings. Don't change it but show a warning if this is the case.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-08 22:52:03 +01:00
DL6ER
90c9ebc54b Ensure empty clients/groups/adlists/audits cannot be added
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-08 22:06:30 +01:00
Adam Warner
5465d93558 Merge pull request #1624 from pi-hole/fix/null_unescape
return null if text passed is null. Don't try to unescape it!
2020-11-08 17:53:12 +00:00
DL6ER
0e924fd910 Add new replace_domain action in groups.php to allow adding domain(s) exclusively to a specific list. In this mode, any occurrences of said domain are first removed from the list before adding the new ones.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-08 18:51:49 +01:00
Adam Warner
78f88d9633 return null if text passed is null. Don't try to unescape it!
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-11-08 17:35:24 +00:00
DL6ER
22f0fd6a27 Merge pull request #1578 from sgtlaggy/fix-query-log-whitelist
Fix Whitelist buttons on query log pages
2020-11-08 18:29:18 +01:00
DL6ER
3739c1600e Merge pull request #1622 from pi-hole/tweak/queryFilters
Add altKey to modifiers when clicking on query log
2020-11-08 17:37:08 +01:00
Adam Warner
638a7db036 Merge pull request #1603 from thislooksfun/devel
Fix html escaping showing up in input fields. (#1584)
2020-11-08 15:40:04 +00:00
Adam Warner
33b660d4fa Merge pull request #1610 from pi-hole/fix/query_retries
Add new query status 12 and 13 (retried queries)
2020-11-08 15:23:00 +00:00
Adam Warner
dc5df4eefa Merge pull request #1600 from rickbau5/fix/enable-ui-elements
Fix UI Remaining Disabled in Groups & Adlists Pages
2020-11-08 15:21:58 +00:00
Adam Warner
e6e3be489b Add altKey to modifiers when clicking on query log
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-11-08 14:58:58 +00:00
Adam Warner
0e43b1f3cf Merge pull request #1563 from yubiuser/tweak/DNSRecordsCNAMETable
Remember last used sort column/direction on Local DNS Records table and CNAME table
2020-11-08 14:23:05 +00:00
Adam Warner
280d31c00f Merge branch 'devel' into fix/group_sel_simple_pages 2020-11-08 13:57:52 +00:00
Adam Warner
56b5e0d3df Merge pull request #1284 from Th3M3/queryads
Use two different divs for mobile and desktop instead of a JS solution
2020-11-08 13:36:59 +00:00
Michael Howell
5624834175 Switch from fontawesome webfonts to SVG + JS
https://discourse.pi-hole.net/t/use-svg-for-icons-instead-of-font/40166

Signed-off-by: Michael Howell <michael@notriddle.com>
2020-11-05 16:49:22 -07:00
XhmikosR
274c196e42 Lint.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-10-26 06:16:04 +00:00
DL6ER
6fcd137ed9 Add new query status 12 and 13 (retried queries).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-10-22 22:30:38 +02:00
Dan Schaper
aa42450ea9 Merge pull request #1489 from pi-hole/XhmikosR-patch-1
Fix HTML validation errors in header.php
2020-10-14 04:13:59 -07:00