Commit Graph

138 Commits

Author SHA1 Message Date
XhmikosR
cecb5aa88c Use $(fn)
This is the recommended way in jQuery 3.x.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-30 10:24:55 +03:00
DL6ER
cce92ccde4 Remove obsolete add.php script, use groups.php everywhere instead.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-26 23:07:20 +02:00
DL6ER
c86515e028 Merge pull request #1372 from pi-hole/indexOf
Always use `!== -1` to check for a string's existence
2020-05-25 20:42:02 +02:00
DL6ER
184c8e47e1 Merge pull request #1332 from pi-hole/tweak/dhcp_save_state
Remember last used sort column/direction on DHCP lease tables
2020-05-25 20:05:45 +02:00
XhmikosR
4356bd5f04 Always use !== -1 to check for a string's existence
`String.indexOf()` returns -1 if the string isn't found so this is consistent with the rest of the codebase.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-25 09:38:47 +03:00
XhmikosR
e70e108cce Use .hidden/.show for showing/hiding the reset buttons
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 13:04:13 +03:00
Adam Warner
3957e9eef1 Move some duplicated code to utils.js
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-23 11:04:30 +03:00
XhmikosR
0fa7de82b0 JS: Enforce camelcase.
It's a common convention to use camelcase for variable names.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 10:29:44 +03:00
DL6ER
b7d74ff772 Reinstall loading overlay on long-term graphs page (shown only if data has been requested).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:50:29 +02:00
DL6ER
ec53843379 Restore coloring of the entire rows in the Query Log
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:50:29 +02:00
DL6ER
6b47a937fb Add network table theming.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:44:55 +02:00
DL6ER
8468f129eb Dark mode optimizations for Query Log and Long-term graphics
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:44:55 +02:00
XhmikosR
8db0957a28 Minor tweaks
* use the background-color property instead of the background shorthand
* add multiple classes with one `addClass` call
* rename `underline` to `text-underline`
* use the CSS class `pointer` instead of adding CSS via JS
* change `border-color: transparent` to `border: 0` in the navbar right dropdown image
* add image dimensions in the dropdown donate image
* remove the obsolete and unneeded `center` element from network.php
* remove commented out PHP code from header.php
* fix wrong `form-control` class used in buttons

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 21:49:48 +03:00
XhmikosR
e02df5467a Fix lint errors.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 09:20:32 +03:00
DL6ER
73ee91a024 Merge branch 'master' into master-to-development-v5.0
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-10 22:00:07 +02:00
DL6ER
cc4e3c9a95 Query Log and long-term data Query Log: Substitute empty domains by "."
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-07 09:17:47 +02:00
DL6ER
2e7b9191fc Update scripts/pi-hole/js/queries.js
Co-Authored-By: TheME <andreas_fl@outlook.com>
2020-04-14 19:54:43 +02:00
XhmikosR
ae13014565 Adapt to the new rules.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-04-10 18:34:47 +00:00
DL6ER
0f21f6d269 Release possible previous onClick event handler on regex links to avoid multiple tabs being opened on click.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-10 10:45:26 +02:00
DL6ER
a64810e00e Merge branch 'release/v5.0' into devel
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-08 12:25:18 +02:00
DL6ER
e328f51e17 Remember last state of the "Apply filtering" checkbox on the Query Log page. Store this browser- not server-wise so individual users can use their own prefered settings.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-31 20:20:17 +00:00
DL6ER
fd7786ad8c Merge pull request #1155 from pi-hole/tweak/show_cname_regex_link
Improve CNAME inspection details on Query Log
2020-02-15 21:59:12 +01:00
DL6ER
8d6e2a07fb Reverse logic on Query Log to ensure only permitted queries can be added to the blacklist.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-15 18:16:56 +01:00
DL6ER
09c7ba99fa Underline clickable regex links on Query Log page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-15 12:25:20 +01:00
DL6ER
88eb4c85b8 Optimizations to regex link generating code.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-14 22:16:06 +01:00
DL6ER
facb5b07a9 Regex IDs start from 1 by default. 0 means the query has been imported from the database. It makes no sense to show a link when we don't know which regex was responsible for blocking (this is not stored in the database).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-14 17:54:34 +01:00
DL6ER
1d7889d754 Add hover title to regex link icon.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-14 17:50:51 +01:00
DL6ER
623cecc64c Also show regex link when this is CNAME regex blocked.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-14 17:41:03 +01:00
DL6ER
249dfc793c Integrate link to regex filter in status column.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-04 22:20:09 +01:00
DL6ER
8fd1631ee3 Add link to regex filter if blocked by one.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-04 08:27:20 +01:00
DL6ER
90a09d1cd0 Fix domain selection for domains containing additional information (such as blocked CNAMEs)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-01-31 06:38:01 +00:00
DL6ER
2fdc676979 Add new CNAME-specific blocking modes [QUERY_GRAVITY_CNAME, QUERY_REGEX_CNAME, QUERY_BLACKLIST_CNAME] and show domain that was the reason for blocking during a CNAME inspection
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-01-29 22:19:26 +00:00
DL6ER
5abbeb2eff Add extra label when blocking happend during deep CNAME inspection.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-01-21 23:34:08 +01:00
Ghalid
d93f1a22cb Remove autocorrect in search boxes on groups
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2020-01-19 13:12:57 -05:00
Ghalid
050fdb1c34 Merge branch 'devel' into patch-1
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2020-01-19 12:49:36 -05:00
XhmikosR
704c352277 Format JS code
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-01-02 19:42:18 +02:00
Adam Warner
73236e8ada Merge pull request #1094 from pi-hole/buttons
Fix buttons appearance
2020-01-02 17:26:28 +00:00
Ghalid
112a5abf80 Merge branch 'devel' into patch-1
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2019-12-29 14:22:12 -05:00
DL6ER
03b3a1d604 Merge pull request #1088 from pi-hole/location
Be explicit about `window.location`
2019-12-28 16:58:27 +01:00
Ghalid
1df9c4049b There should only be one search input on each page so there doesn't need to be an array anyway, remove arrow functions as per https://github.com/pi-hole/AdminLTE/pull/1100\#pullrequestreview-335618314
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>

Remove const

Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2019-12-21 14:51:34 -05:00
Ghalid
40d7e1498e Disable autocorrect in search boxes
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2019-12-21 12:06:48 -05:00
XhmikosR
d017c57f84 Fix buttons appearance
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 17:50:50 +02:00
DL6ER
f084fa1991 Merge pull request #1091 from pi-hole/text
Use `text()` for the token
2019-12-17 15:49:05 +01:00
XhmikosR
f486935eb8 Use text() for the token
We don't need any HTML.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 15:57:50 +02:00
XhmikosR
2ba18a1b58 Be explicit about window.location
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 12:14:37 +02:00
XhmikosR
9c1846885a Clean up JS
* remove unused variables/functions
* use the dot notation
* use explicit coercion
* remove unneeded else
* use `textContent` instead of `innerHTML`
* cache a few `getElementById` calls
* fix a couple of undefined variables
* various assorted lint tweaks

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-16 20:36:40 +02:00
XhmikosR
d65b5be5e2 A few CSS tweaks.
Add utilities classes and fix a few CSS issues.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-09 21:36:58 +02:00
XhmikosR
37c849ce2b Remove unused variables
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-07 11:49:49 +02:00
denny0754
8991605f04 Fixed Issue#983 2019-08-01 18:14:32 +01:00
Mcat12
8157fa5c8e Don't show the "Click to ..." tooltip when filtering is disabled
Fixes #971

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-06-28 20:14:05 -07:00