Commit Graph

232 Commits

Author SHA1 Message Date
Adam Warner
a28f4e4f18 Prevent malformed DNS queries executing JS on querylog/long term query log
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-12-23 18:11:14 +00:00
dnhp
ef6a740370 Fix issue 1643 - quote numbers in switch case
Signed-off-by: dnhp <34394848+dnhp@users.noreply.github.com>
2020-12-01 12:04:16 +00:00
Adam Warner
483f5037db Merge pull request #1625 from pi-hole/tweak/replace_domains
Add new replace_domain action to allow adding domain(s) exclusively to a specific list
2020-11-28 16:25:38 +00:00
DL6ER
4ee491115a Show upstream destination a query was sent to in the Query Log (both standard and long-term)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-13 01:01:49 +01:00
DL6ER
a3b24e08aa Reduce code-duplication by moving the addFromQueryLog() function into utils.js. This also fixes non-visible modals on the long-term query log page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-09 21:33:09 +01:00
DL6ER
ad43e5a8dc Add missing space and extend error hiding timeout from 4 to 10 seconds.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-09 21:21:30 +01:00
DL6ER
0e924fd910 Add new replace_domain action in groups.php to allow adding domain(s) exclusively to a specific list. In this mode, any occurrences of said domain are first removed from the list before adding the new ones.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-11-08 18:51:49 +01:00
DL6ER
3739c1600e Merge pull request #1622 from pi-hole/tweak/queryFilters
Add altKey to modifiers when clicking on query log
2020-11-08 17:37:08 +01:00
Adam Warner
33b660d4fa Merge pull request #1610 from pi-hole/fix/query_retries
Add new query status 12 and 13 (retried queries)
2020-11-08 15:23:00 +00:00
Adam Warner
e6e3be489b Add altKey to modifiers when clicking on query log
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-11-08 14:58:58 +00:00
XhmikosR
274c196e42 Lint.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-10-26 06:16:04 +00:00
DL6ER
6fcd137ed9 Add new query status 12 and 13 (retried queries).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-10-22 22:30:38 +02:00
Adam Warner
0db41baa23 Simplify query log filter.
Don't require modifier keys to interact (now works on mobile)
Hold modifier key to enable selection for copying domain (long press on mobile)

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-10-12 17:41:38 +01:00
DL6ER
ebe6527ab7 Merge pull request #1541 from pi-hole/fix/wording_query_log_links
Fix a few UI issues
2020-08-15 13:07:37 +02:00
DL6ER
64a2419fa9 Add ability to filter for blocked queries in conjunction the client filter in the Query Log. Request such filtered data when clicking on a client in the Top Clients (blocked only) table on the dashboard.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-08-02 19:54:54 +02:00
Adam Warner
e0cd37b781 Merge branch 'release/v5.1' into ip-sorting-query 2020-07-16 18:38:53 +01:00
DL6ER
1819abee76 Merge branch 'devel' into tweak/exact_searching 2020-06-14 20:48:08 +02:00
Adam Warner
606568054a enable IP sorting on the query/long-term query pages. Appears to work with a mixture of hostnames/IP's
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-06-07 11:09:20 +01:00
DL6ER
4bf018b52c Add missing radix information in parseInt().
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 16:57:55 +02:00
DL6ER
f4fe04dd16 Add placeholder to the search field to highlight what can be searched for
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 10:52:35 +02:00
DL6ER
fafdf37533 Remove parseInt() from values guaranteed to be int from the API.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 10:38:51 +02:00
DL6ER
3d423ede5f Use classes instead of manipulating CSS directly for getting the pointer.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 10:26:54 +02:00
DL6ER
e357a925b5 Add tooltip and click cursor to enhance accessibility of the click filtering feature.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 10:08:13 +02:00
DL6ER
68e03df011 Simplify button by removing the description of what we are filtering.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 09:44:22 +02:00
DL6ER
55ab4f179f Minor style changes for the dark theme.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-03 15:51:39 +02:00
DL6ER
9b8946ee9f Merge branch 'devel' into tweak/exact_searching
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-03 15:21:12 +02:00
DL6ER
578477148b On fast machines, cache replies can be served within less than 100 nanoseconds. The query log should show "(0.0ms)" in this case instead of hiding the value altogether.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-02 13:21:34 +02:00
XhmikosR
cecb5aa88c Use $(fn)
This is the recommended way in jQuery 3.x.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-30 10:24:55 +03:00
DL6ER
cce92ccde4 Remove obsolete add.php script, use groups.php everywhere instead.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-26 23:07:20 +02:00
DL6ER
c86515e028 Merge pull request #1372 from pi-hole/indexOf
Always use `!== -1` to check for a string's existence
2020-05-25 20:42:02 +02:00
DL6ER
184c8e47e1 Merge pull request #1332 from pi-hole/tweak/dhcp_save_state
Remember last used sort column/direction on DHCP lease tables
2020-05-25 20:05:45 +02:00
XhmikosR
4356bd5f04 Always use !== -1 to check for a string's existence
`String.indexOf()` returns -1 if the string isn't found so this is consistent with the rest of the codebase.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-25 09:38:47 +03:00
XhmikosR
e70e108cce Use .hidden/.show for showing/hiding the reset buttons
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 13:04:13 +03:00
Adam Warner
3957e9eef1 Move some duplicated code to utils.js
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-23 11:04:30 +03:00
XhmikosR
0fa7de82b0 JS: Enforce camelcase.
It's a common convention to use camelcase for variable names.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 10:29:44 +03:00
DL6ER
b7d74ff772 Reinstall loading overlay on long-term graphs page (shown only if data has been requested).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:50:29 +02:00
DL6ER
ec53843379 Restore coloring of the entire rows in the Query Log
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:50:29 +02:00
DL6ER
6b47a937fb Add network table theming.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:44:55 +02:00
DL6ER
8468f129eb Dark mode optimizations for Query Log and Long-term graphics
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:44:55 +02:00
XhmikosR
8db0957a28 Minor tweaks
* use the background-color property instead of the background shorthand
* add multiple classes with one `addClass` call
* rename `underline` to `text-underline`
* use the CSS class `pointer` instead of adding CSS via JS
* change `border-color: transparent` to `border: 0` in the navbar right dropdown image
* add image dimensions in the dropdown donate image
* remove the obsolete and unneeded `center` element from network.php
* remove commented out PHP code from header.php
* fix wrong `form-control` class used in buttons

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 21:49:48 +03:00
XhmikosR
e02df5467a Fix lint errors.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 09:20:32 +03:00
DL6ER
73ee91a024 Merge branch 'master' into master-to-development-v5.0
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-10 22:00:07 +02:00
DL6ER
cc4e3c9a95 Query Log and long-term data Query Log: Substitute empty domains by "."
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-07 09:17:47 +02:00
DL6ER
6c26852295 Use classes for highlighting to ensure the alternate row colors are not lost when removing a column from the selection.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-26 21:51:38 +00:00
DL6ER
cb3be64a23 Simply reply type code.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-26 09:57:11 +02:00
DL6ER
4d9409e708 Apply filtering events only on Ctrl/Command/Shift + Click.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-25 15:20:58 +02:00
DL6ER
1466ecd486 Add reply type filtering.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-25 15:04:09 +02:00
DL6ER
82f4549219 Add filtering on status column.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-25 06:39:00 +02:00
DL6ER
fcd4751cb7 Implement selective undoing using the Shift key.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-24 12:09:55 +02:00
DL6ER
6f2a878371 Store filtering columns in array instead of in a string. This makes adding a column multiple times impossible.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-24 11:50:55 +02:00