Commit Graph

1199 Commits

Author SHA1 Message Date
XhmikosR
8db0957a28 Minor tweaks
* use the background-color property instead of the background shorthand
* add multiple classes with one `addClass` call
* rename `underline` to `text-underline`
* use the CSS class `pointer` instead of adding CSS via JS
* change `border-color: transparent` to `border: 0` in the navbar right dropdown image
* add image dimensions in the dropdown donate image
* remove the obsolete and unneeded `center` element from network.php
* remove commented out PHP code from header.php
* fix wrong `form-control` class used in buttons

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 21:49:48 +03:00
XhmikosR
e02df5467a Fix lint errors.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 09:20:32 +03:00
DL6ER
73ee91a024 Merge branch 'master' into master-to-development-v5.0
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-10 22:00:07 +02:00
Adam Warner
d8706620de Replace paypal link with link to pi-hole.net donate page
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-09 12:57:15 +01:00
DL6ER
cc4e3c9a95 Query Log and long-term data Query Log: Substitute empty domains by "."
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-07 09:17:47 +02:00
DL6ER
b86ff763c0 Address xo complaints.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-07 07:52:18 +02:00
Adam Warner
68ce56fc56 show a clickable "." when there is a blank domain in the top domain lists
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-06 23:19:50 +01:00
XhmikosR
bdde1e6667 Use text() when retrieving the token. (#1237)
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-04 10:52:00 +03:00
XhmikosR
0e35b415ea JS: test for length explicitly. (#1240)
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-04 10:50:13 +03:00
Adam Warner
6e5bbfb68a Check IP addresses read in from dns-server.conf are valid before adding them to the array.
Fix for CVE-2020-12620

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-03 22:47:33 +01:00
DL6ER
81a2932f6a Merge branch 'release/v5.0' into tweak/trim_domains_input
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-28 21:12:45 +02:00
Dan Schaper
eaf2d7ed62 Merge pull request #1226 from pi-hole/tweak/allow_()_in_urls
Allow ( and ) in adlist URLs.
2020-04-28 11:46:32 -07:00
DL6ER
527c2f114b Merge pull request #1229 from pi-hole/tweak/custom_dns
Custom DNS page -> Local DNS Records
2020-04-28 20:30:23 +02:00
DL6ER
9cf73959fd Rename Custom DNS page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-28 18:23:13 +00:00
DL6ER
abf6e9f7a2 Merge pull request #1210 from pi-hole/fix/regex_link_multiple_tabs
Prevent multiple tabs from being opened when clicking on a regex link on the Query Log page
2020-04-28 20:06:03 +02:00
DL6ER
4889350038 Merge branch 'release/v5.0' into tweak/trim_domains_input
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-28 17:30:13 +00:00
DL6ER
79539bdd6c Merge pull request #1121 from pi-hole/fix/queries_over_time
Fix tooltip percentage computation and more...
2020-04-28 04:36:02 +02:00
DL6ER
84046528bf Allow ( and ) in adlist URLs.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-26 09:31:45 +02:00
DL6ER
f17b216b6b As of ICU 55.1 (released 2015-04-01) the IDNA2003 APIs are deprecated, because UTS #46 should be preferred over the obsolete IDNA 2003 variant. Implement this change. Fixes #1223
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-25 07:02:37 +02:00
DL6ER
77b421b133 Show how many domains have been added in case of an error.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-23 13:47:50 +02:00
DL6ER
7d1163ff9c Try to be clearer with the "failed to add domain" message by showing the original input when idn_to_ascii() failed and by showing both, the original and the converted domain when the conversion result itself is invalid.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-23 11:39:57 +02:00
DL6ER
14dd1350df Strip whitespaces from the beginning and end of user input to prevent errors getting triggered due to users trying to add "empty" domains.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-23 11:27:24 +02:00
DL6ER
c49bcb1454 Merge pull request #1147 from Th3M3/fix/custom_tooltips
tweak chartjs customtooltips
2020-04-21 16:34:19 +02:00
DL6ER
c1ddf66487 Merge pull request #1206 from pi-hole/fix/dhcp_static_error
Check for existence and readability of static leases file before trying to access it
2020-04-21 10:07:15 +02:00
Samu Voutilainen
39ec67829b Execute pihole through wrapper
All different exec() calls basically just calls sudo pihole,
with various different syntaxes. Using a wrapper function
allows sanitization of arguments for better safety.

Signed-off-by: Samu Voutilainen <smar@smar.fi>
2020-04-17 07:55:16 +03:00
DL6ER
2e7b9191fc Update scripts/pi-hole/js/queries.js
Co-Authored-By: TheME <andreas_fl@outlook.com>
2020-04-14 19:54:43 +02:00
DL6ER
8ad3b70f96 We should also accept open-ended IPv6 addresses such as, e.g., fda2:2001:5555::
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-13 09:48:08 +02:00
Th3M3
fadc6073db tweak chartjs customtooltips...
...and disable 'maintainAspectRatio' for the clients chart to avoid a squeezed display on small screens.

Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-12 15:25:29 +02:00
XhmikosR
ae13014565 Adapt to the new rules.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-04-10 18:34:47 +00:00
DL6ER
0f21f6d269 Release possible previous onClick event handler on regex links to avoid multiple tabs being opened on click.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-10 10:45:26 +02:00
DL6ER
a64810e00e Merge branch 'release/v5.0' into devel
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-08 12:25:18 +02:00
DL6ER
43b45d3da7 Merge pull request #1100 from Ghalid/patch-1
Disable text correction features, change types to make input fields easier to type in (especially for mobile devices)
2020-04-07 13:59:44 +02:00
DL6ER
0f892c9ffc Check for existance and readability of static leases file before trying to access it.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-07 12:30:51 +02:00
Th3M3
3ea59d5d36 shorter button textes & cleanup
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-05 20:49:53 +02:00
Th3M3
fd983a2b68 improve multiselect
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-05 14:56:28 +02:00
DL6ER
0a81dadf2f Merge pull request #1161 from pi-hole/tweak/wrap_other_tables
Add class "breakall" also to the code fields in the other tables.
2020-03-31 23:43:25 +02:00
DL6ER
f9fd89cda7 Merge pull request #1149 from pi-hole/new/space-separated-item-injection
Allow space separated multiple items injection
2020-03-31 23:40:39 +02:00
DL6ER
57e139bcba Merge branch 'release/v5.0' into new/space-separated-item-injection 2020-03-31 21:31:41 +00:00
DL6ER
1e22f3349f Merge branch 'release/v5.0' into fix/queries_over_time 2020-03-31 21:22:18 +00:00
DL6ER
6e98c41a4f Merge branch 'release/v5.0' into tweak/wrap_other_tables 2020-03-31 21:11:30 +00:00
Adam Warner
45f98ae0f5 Merge pull request #1176 from pi-hole/master-xmr-btn
Streamline button classes and display.
2020-03-31 22:09:23 +01:00
DL6ER
7d2d9c29db Merge pull request #1199 from pi-hole/tweak/remember_filtering_chkbox
Remember last state of the "Apply filtering" checkbox on the Query Log page
2020-03-31 23:08:09 +02:00
DL6ER
e2ca6bc920 Merge pull request #1187 from pi-hole/new/all_clients_network_table
Hide mock hardware addresses
2020-03-31 23:07:59 +02:00
Adam Warner
1dbbd3583c Merge pull request #1190 from Th3M3/fix/allow_empty_emailaddress
allow to clear email address
2020-03-31 22:07:13 +01:00
DL6ER
f0034b305d Check adlist URL for valid characters before adding record to the database.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-31 20:41:50 +00:00
DL6ER
e328f51e17 Remember last state of the "Apply filtering" checkbox on the Query Log page. Store this browser- not server-wise so individual users can use their own prefered settings.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-31 20:20:17 +00:00
Rick van Hattem
0c29a09a45 Add correct IP sorting for the Custom DNS table
Signed-off-by: Rick van Hattem <Wolph@wol.ph>
2020-03-30 22:29:47 +02:00
DL6ER
6fdeee53ca Merge pull request #1181 from pi-hole/tweak/client_address_validation
Add IPv4/IPv6 address validation to clients management page
2020-03-28 15:02:35 +01:00
XhmikosR
4af6a0785a Update xo to v0.28.0
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-03-20 10:31:32 +02:00
Th3M3
2a38bcc074 allow to clear email address
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-03-18 21:39:55 +01:00