Commit Graph

243 Commits

Author SHA1 Message Date
Paul Mannarino
59ca7971c2 Resolve code quality issues
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-12-02 19:20:43 -05:00
Paul Mannarino
63b27dc9d1 Run prettier
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-12-02 18:47:03 -05:00
Paul Mannarino
a8743115fd Merge remote-tracking branch 'upstream/devel' into feat/avoid-window-open
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-12-02 18:31:43 -05:00
Paul Mannarino
f67780bb07 Remove backticks
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-12-02 18:26:34 -05:00
Paul Mannarino
fc30e45ccd Re-add comment
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-12-02 18:20:08 -05:00
Paul Mannarino
aa3c8aef5f reduce functions
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-12-02 18:08:24 -05:00
Paul Mannarino
35396a6cb5 Clean up
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-12-02 13:31:14 -05:00
Paul Mannarino
05d56d12d5 Update pie chart slice toggle
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-12-02 13:12:08 -05:00
Paul Mannarino
cb6b3480a5 Avoid window.open
Signed-off-by: Paul Mannarino <paul.mannarino@gmail.com>
2021-11-30 23:13:53 -05:00
Christian König
e3709571c3 Fix zeroLineColor in all graphs
Signed-off-by: Christian König <ckoenig@posteo.de>
2021-11-19 19:44:17 +01:00
DL6ER
0d0a8dba67 Change prettier option trailingComma from "none" to the new default "es5" (see https://prettier.io/docs/en/options.html#trailing-commas)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2021-06-23 11:26:43 +02:00
DL6ER
cfce364c84 Change tooltip wording to "% of shown items" to be more universal
Signed-off-by: DL6ER <dl6er@dl6er.de>
2021-01-19 08:04:22 +01:00
DL6ER
02389490dc Also compute and show share of displayed quantities in the doghount charts (only if some items are hidden)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2021-01-19 07:59:07 +01:00
DL6ER
92dbd9dd37 Only add link to Query Log when filtering property is available
Signed-off-by: DL6ER <dl6er@dl6er.de>
2021-01-19 07:11:11 +01:00
Dan Schaper
e763993574 unicorn/prefer-dom-node-append
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2021-01-02 20:33:14 -08:00
DL6ER
835f12ddec Merge pull request #1594 from yubiuser/tweak/colors
Change color of blocked queries in dashboard piechart forward destination to red
2020-12-10 22:08:35 +01:00
XhmikosR
274c196e42 Lint.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-10-26 06:16:04 +00:00
yubiuser
6bb07ec808 Change color of blocked queries in dashboard piechart forward destinations to red
Signed-off-by: yubiuser <ckoenig@posteo.de>
2020-09-30 20:19:32 +02:00
DL6ER
ebe6527ab7 Merge pull request #1541 from pi-hole/fix/wording_query_log_links
Fix a few UI issues
2020-08-15 13:07:37 +02:00
DL6ER
01aca3242f Add link to Query Log from Clients over Time bar graph bars.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-08-02 20:05:49 +02:00
DL6ER
64a2419fa9 Add ability to filter for blocked queries in conjunction the client filter in the Query Log. Request such filtered data when clicking on a client in the Top Clients (blocked only) table on the dashboard.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-08-02 19:54:54 +02:00
DL6ER
d647792655 Fix query types links on the dashboard (Query Types pie chart)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-07-20 22:33:17 +02:00
DL6ER
aeba7c958d Only show query types for which the count is larger than zero.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-28 21:41:39 +02:00
DL6ER
4bf018b52c Add missing radix information in parseInt().
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 16:57:55 +02:00
DL6ER
80873e83e8 Modify how we add data to the stacked bar charts on the dashboard.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 13:24:34 +02:00
XhmikosR
a70eb512c0 Remove unneeded chart.update() calls.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-06-03 17:38:38 +03:00
XhmikosR
3b22d681ff Specify animation: false for the bar graphs
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-06-03 17:38:35 +03:00
Adam Warner
02a4e83d87 create utils.getGraphType() function.
also apply setting to long term graphs
flip logic - only return "line" if the setting is explicitly set to "false"

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-06-01 21:10:14 +01:00
XhmikosR
cecb5aa88c Use $(fn)
This is the recommended way in jQuery 3.x.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-30 10:24:55 +03:00
XhmikosR
7caabf7d2a index.js: assorted simplifications
Signed-off-by: XhmikosR <xhmikosr@gmail.com>

* rename `colors` variable to avoid shadowing and be more clear
* remove function used only once
* simplify a couple of for loops
2020-05-29 11:11:34 +03:00
XhmikosR
61c29cafc4 Move padNumber() to utils.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-29 11:11:34 +03:00
XhmikosR
7f71f1d5fe Move objectToArray() to utils.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-29 11:11:32 +03:00
XhmikosR
eab6485edb Move escapeHtml to utils.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-29 07:41:05 +03:00
XhmikosR
9b3d8b81e7 Replace $.each with native methods.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-26 06:34:27 +03:00
DL6ER
c86515e028 Merge pull request #1372 from pi-hole/indexOf
Always use `!== -1` to check for a string's existence
2020-05-25 20:42:02 +02:00
DL6ER
b6ad648842 Merge pull request #1329 from pi-hole/new/somepeoplelikecurves
Add checkbox (save state in localstorage) to toggle between bar and smooth
2020-05-25 20:08:42 +02:00
XhmikosR
4356bd5f04 Always use !== -1 to check for a string's existence
`String.indexOf()` returns -1 if the string isn't found so this is consistent with the rest of the codebase.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-25 09:38:47 +03:00
Adam Warner
c4091a7b3b Add checkbox (save state in localstorage) to toggle between bar and smooth charts
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-18 20:56:21 +01:00
XhmikosR
623087346a Enable no-zero-fractions rule
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-17 15:03:52 +03:00
Adam Warner
dcf3c42924 flip null check on elName. === null was not working
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-17 11:46:50 +01:00
Adam Warner
b351f45cb2 Change the names of the info elements without changing the property names of the API
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-15 09:25:01 +01:00
DL6ER
b7d74ff772 Reinstall loading overlay on long-term graphs page (shown only if data has been requested).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:50:29 +02:00
DL6ER
a08a85994e Initial (incomplete) support for themes. Currently, the default is the new Pi-hole dark theme.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:44:52 +02:00
DL6ER
2314a60d5b Get an endless array of colors without altering the colors array itself.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 17:16:55 +02:00
XhmikosR
7001a1b3a1 Update index.js 2020-05-12 17:58:34 +03:00
Adam Warner
d10f1905cc fix prettier complaints
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-12 13:21:30 +01:00
Adam Warner
3e94ff0f43 Update adminLTE to 2.4.
- Change a few references per upgrade guide
 - define colors[] at the top of index.js as AdminLTE.options does not appear to exist. (there may be a better way of doing this)

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-12 12:58:45 +01:00
XhmikosR
e02df5467a Fix lint errors.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 09:20:32 +03:00
DL6ER
73ee91a024 Merge branch 'master' into master-to-development-v5.0
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-10 22:00:07 +02:00
DL6ER
b86ff763c0 Address xo complaints.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-07 07:52:18 +02:00