Commit Graph

520 Commits

Author SHA1 Message Date
DL6ER
a80355cf2f Improve error messages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-23 15:19:52 +00:00
DL6ER
cce7c928d5 We have to get the group's ID from the hidden field now that we removed/hide the IP column by default.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-23 15:13:51 +00:00
DL6ER
772d52c09a Reset visibility of ID column on table loading
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-20 08:52:21 +00:00
DL6ER
ede9d41341 Add "Reset Sorting" button to remaining pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-20 08:35:29 +00:00
DL6ER
4f54796286 Add auto-saving to all group management pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-20 08:30:47 +00:00
DL6ER
26c9a55ad5 Add tooltip to group name input fields.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-20 08:20:44 +00:00
DL6ER
1c3d635d2b Include but hide ID column on the group management page. Add "Reset sorting" button enabling the user to go back to ID sorting (initial behavior, makes sure group 0 is at the top).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-20 08:16:28 +00:00
DL6ER
4aa3551734 Remove ID displaying for groups from all pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-20 00:42:17 +00:00
DL6ER
5e2561aa91 Remove ID column from group management page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-20 00:38:37 +00:00
DL6ER
5aa6b1de59 Sort by first column by default (zero-indexed)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-19 20:04:29 +00:00
DL6ER
a2031c0d1f Replace pencil button by automatic saving (so far, only for the groups.php page)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-19 17:30:18 +00:00
DL6ER
050021827f Show host names (if known) on the Clients management page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-19 16:56:44 +00:00
DL6ER
ae08443fa5 Merge branch 'devel' into new/group-management 2019-12-17 15:06:45 +00:00
DL6ER
59b04047d6 Merge pull request #1086 from pi-hole/js-license-header
Add missing license header
2019-12-17 15:56:31 +01:00
DL6ER
aad00db5b6 Merge pull request #1085 from pi-hole/reuse-dateformat
Reuse the `dateformat` variable
2019-12-17 15:55:41 +01:00
DL6ER
f9496c5c6e Merge pull request #1087 from pi-hole/let
Use var instead of let.
2019-12-17 15:54:01 +01:00
DL6ER
49df077a66 Merge pull request #1089 from pi-hole/XhmikosR-patch-2
Reuse variable and make code clearer
2019-12-17 15:53:32 +01:00
DL6ER
f084fa1991 Merge pull request #1091 from pi-hole/text
Use `text()` for the token
2019-12-17 15:49:05 +01:00
XhmikosR
f486935eb8 Use text() for the token
We don't need any HTML.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 15:57:50 +02:00
DL6ER
51edb07537 Use titles in notifications.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-17 13:56:32 +00:00
DL6ER
da2d92ebd7 Prevent users from adding empty groups/domains/clients/adlists.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-17 12:57:45 +00:00
DL6ER
d0d1174010 Use bootstrap notify for notifications.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-17 12:48:25 +00:00
DL6ER
232cfdb326 Also show database ID in tooltip.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-17 11:35:57 +00:00
XhmikosR
18cfd8dab1 Reuse variable and make code clearer
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 12:19:43 +02:00
XhmikosR
ef396ede5b Use var instead of let.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 10:47:01 +02:00
XhmikosR
689aa6afd6 Add missing license headers
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 10:46:36 +02:00
XhmikosR
7d9e32bac6 Reuse the dateformat variable
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 09:59:01 +02:00
XhmikosR
9c1846885a Clean up JS
* remove unused variables/functions
* use the dot notation
* use explicit coercion
* remove unneeded else
* use `textContent` instead of `innerHTML`
* cache a few `getElementById` calls
* fix a couple of undefined variables
* various assorted lint tweaks

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-16 20:36:40 +02:00
XhmikosR
97bc779299 db_graph.js: Fix IE 11
IE doesn't support `Array.includes()`

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-16 19:29:24 +02:00
DL6ER
8c20ac58b9 Merge pull request #1072 from pi-hole/js
settings.js: fix object shorthand
2019-12-16 12:57:45 +01:00
DL6ER
95c893ded5 Merge branch 'devel' into new/group-management 2019-12-16 10:28:36 +00:00
DL6ER
52f5be0c8f Merge pull request #992 from trimalcione/devel
Add DHCP leases export/import from teleporter
2019-12-16 11:22:28 +01:00
DL6ER
7c9d77d694 Run prettier on most recent changes.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-16 09:46:38 +00:00
DL6ER
509574b6ab Show raw response (like "Not allowed") when encountering an error. This is actually not all that unlikely as a user might have the page open for longer time and wants to add(edit/delete a group/client/domain/adlist when their session has already expired.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-16 09:43:22 +00:00
DL6ER
6f3495db7b Send token when adding new group. Otherwise, we get a "Not allowed" response.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-16 09:36:50 +00:00
trimalcione
03326ebe09 fix DHCP tab syncing after telereporter import
Signed-off-by: trimalcione <okchtioui@gmail.com>
2019-12-16 00:37:23 +01:00
DL6ER
6bc72d296c Use JS dot-notation as it is less verbose
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-14 20:19:09 +00:00
DL6ER
a75117a584 Use prettier to reformat JS files added in this PR.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-14 20:06:26 +00:00
DL6ER
aa6c4c88f3 Ensure large table is only loaded when groups are known.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 17:54:01 +00:00
DL6ER
aa764ad22d Add CORS and CSRF checks to ensure unauthorized access to the backend is not possible.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 17:39:45 +00:00
DL6ER
9950ca50fe Correctly interpret toogle value.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 17:23:10 +00:00
DL6ER
a83c9c9828 Add tooltips for creation and modification times for domains and adlists.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 17:22:20 +00:00
DL6ER
b62c550ad7 Use toggle for Enabled/Disabled switch
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 16:45:24 +00:00
DL6ER
50f05b9119 Add missing form-control classes for proper element styling.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 16:19:45 +00:00
DL6ER
b025ffd208 Make sure all fields are searchable on all pages (where this is meaningful) and remove ID column from clients group page.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 15:59:46 +00:00
DL6ER
70589fa844 Add Adlists group management
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 15:41:14 +00:00
DL6ER
912e2ddbd9 Add Domain Group Management
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 15:29:42 +00:00
DL6ER
600c16c269 Add Client group management
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 14:40:29 +00:00
DL6ER
3e23aa67a1 Add group management page
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-13 11:55:22 +00:00
XhmikosR
d91b605563 settings.js: fix object shorthand
This broke IE

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-11 00:30:08 +02:00