Commit Graph

51 Commits

Author SHA1 Message Date
DL6ER
a901489a96 Merge branch 'devel' into new/mac_clients
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-05 22:24:17 +02:00
DL6ER
4bf018b52c Add missing radix information in parseInt().
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 16:57:55 +02:00
XhmikosR
ff16f4889b network.js: minor consistency changes
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-30 18:20:18 +03:00
XhmikosR
cecb5aa88c Use $(fn)
This is the recommended way in jQuery 3.x.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-30 10:24:55 +03:00
DL6ER
eb3c672545 Show explicitly which hostname belongs to which IP address when hovering over the hostnames. Note that the IP addresses and host names were already in the same order, before.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-27 19:59:53 +02:00
DL6ER
c86515e028 Merge pull request #1372 from pi-hole/indexOf
Always use `!== -1` to check for a string's existence
2020-05-25 20:42:02 +02:00
DL6ER
184c8e47e1 Merge pull request #1332 from pi-hole/tweak/dhcp_save_state
Remember last used sort column/direction on DHCP lease tables
2020-05-25 20:05:45 +02:00
DL6ER
61a3ec1b2b Merge pull request #1298 from pi-hole/XhmikosR-patch-5
Enable `no-zero-fractions` rule
2020-05-25 19:48:01 +02:00
XhmikosR
4356bd5f04 Always use !== -1 to check for a string's existence
`String.indexOf()` returns -1 if the string isn't found so this is consistent with the rest of the codebase.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-25 09:38:47 +03:00
Adam Warner
3957e9eef1 Move some duplicated code to utils.js
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-23 11:04:30 +03:00
XhmikosR
0fa7de82b0 JS: Enforce camelcase.
It's a common convention to use camelcase for variable names.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 10:29:44 +03:00
XhmikosR
623087346a Enable no-zero-fractions rule
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-17 15:03:52 +03:00
XhmikosR
0b3371030f network: use Font Awesome
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-17 08:51:07 +03:00
DL6ER
389f1d1ecd Fix failed git auto-merge.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-14 20:29:42 +02:00
DL6ER
3e1a1f59aa Add support for multiple hostnames per client (hardware address).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-14 18:43:35 +02:00
DL6ER
b7d74ff772 Reinstall loading overlay on long-term graphs page (shown only if data has been requested).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:50:29 +02:00
DL6ER
b5e64653db Update network colors
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:50:29 +02:00
DL6ER
6b47a937fb Add network table theming.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-12 22:44:55 +02:00
XhmikosR
ae13014565 Adapt to the new rules.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-04-10 18:34:47 +00:00
DL6ER
a64810e00e Merge branch 'release/v5.0' into devel
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-08 12:25:18 +02:00
DL6ER
a99bfeaa6c Set hostname to italic unknown if not available
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-12 19:27:08 +00:00
DL6ER
d89b13cf6c Hide mock hardware addresses
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-03-12 19:25:43 +00:00
DL6ER
4228d88336 xo does neither like const nor let. Use var everywhere.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-03 23:16:49 +01:00
DL6ER
86f56ee5df Make IP addresses links that send to the Query Log.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-03 22:51:15 +01:00
Ghalid
d93f1a22cb Remove autocorrect in search boxes on groups
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2020-01-19 13:12:57 -05:00
Ghalid
050fdb1c34 Merge branch 'devel' into patch-1
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2020-01-19 12:49:36 -05:00
XhmikosR
704c352277 Format JS code
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-01-02 19:42:18 +02:00
XhmikosR
25af37509e length cannot be negative
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-29 10:13:50 +02:00
Ghalid
1df9c4049b There should only be one search input on each page so there doesn't need to be an array anyway, remove arrow functions as per https://github.com/pi-hole/AdminLTE/pull/1100\#pullrequestreview-335618314
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>

Remove const

Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2019-12-21 14:51:34 -05:00
Ghalid
40d7e1498e Disable autocorrect in search boxes
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2019-12-21 12:06:48 -05:00
XhmikosR
9c1846885a Clean up JS
* remove unused variables/functions
* use the dot notation
* use explicit coercion
* remove unneeded else
* use `textContent` instead of `innerHTML`
* cache a few `getElementById` calls
* fix a couple of undefined variables
* various assorted lint tweaks

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-16 20:36:40 +02:00
XhmikosR
5275faacb1 Lowercase hex colors.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-09 16:53:21 +02:00
Adam Warner
b7d3ddd2b0 Merge branch 'devel' into release/v4.3.2 2019-09-22 00:58:42 +01:00
DL6ER
83013993cd Also show "N/A" if the name column is NULL
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:50 -04:00
DL6ER
a027715247 Move ip-address-sorting into its own file
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:49 -04:00
DL6ER
f830bfbc7b Add IP address sorting for the network table, based on https://datatables.net/plug-ins/sorting/ip-address
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:48 -04:00
DL6ER
c8086b4239 Check fields against null before trying to obtain their lengths.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:47 -04:00
DL6ER
f0458e518a Disable ordering by IP address as this is not really meaningful if we have multiple IPs in each row
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-06-14 19:19:53 +02:00
DL6ER
425b6ba5a7 Show at only the three most recent IP addresses for each device. The hover text of contains all IP addresses.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-06-14 19:17:52 +02:00
DL6ER
0e2d30dd11 Also show "N/A" if the name column is NULL
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-05-30 12:48:53 +02:00
DL6ER
dddc791052 Move ip-address-sorting into its own file
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-05-30 12:44:09 +02:00
DL6ER
5f79025cc9 Add IP address sorting for the network table, based on https://datatables.net/plug-ins/sorting/ip-address
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-05-30 12:30:55 +02:00
DL6ER
09eb4f5dc3 Check fields against null before trying to obtain their lengths.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-05-30 12:24:43 +02:00
Adam Warner
0d0d44939d Set "orderable" to false on last column, as sorting does not work here!
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2019-05-02 21:58:14 +01:00
DL6ER
d07eafc964 Review comments
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-01-07 18:56:56 +01:00
DL6ER
496af21131 Javascript optimizations
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-01-06 20:56:06 +01:00
DL6ER
93b4513980 Display vendor information for devices where available
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-12-31 00:23:09 +01:00
DL6ER
cfc3cba10c Make the client column clickable and send the user to the correspondignly filtered Query Log page on click
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-12-29 20:48:07 +01:00
DL6ER
67b67de4a9 Add "uses Pi-hole" column
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-12-28 12:15:16 +01:00
DL6ER
7030a33d26 Use localized integers for numbers
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-12-27 15:14:45 +01:00