Commit Graph

115 Commits

Author SHA1 Message Date
DL6ER
858a916dcb Top Clients (blocked only) tooltip should show total number of blocked queries. The percentage is already computed correctly.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-11-02 11:07:43 +01:00
DL6ER
df6fd5e1c4 Use correct IDs for spinners in index.js
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-08-27 16:56:42 +02:00
DL6ER
d616a1180a Check data before converting. This allows us to detect if there is no data for the graph so we can hide it. Fixes #932
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-06-15 17:20:49 +02:00
DL6ER
635bdfb717 Undo removal of slice operations
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-17 11:52:14 +01:00
DL6ER
e433e90308 Remove dead code from scripts/pi-hole/js/index.js
Removed:
- updateForwardedOverTime();
- updateQueryTypesOverTime();
- slicing on overTime data

Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-11 00:52:24 +01:00
DL6ER
56251d1808 Forward destinations -> Upstreams
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-09-24 12:55:55 +02:00
Mark Drobnak
d7b328e103 Use doublequote strings and add comment
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com>
2018-08-16 17:47:05 -04:00
Mark Drobnak
6af8c76c3f Use random colors in client graph if presets run out
Signed-off-by: Mark Drobnak <newtoncat12@yahoo.com>
2018-08-16 17:38:02 -04:00
DL6ER
55969fab4b A = 1, AAAA = 2, ...
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-15 15:20:27 +02:00
DL6ER
a72dbd8f91 :codacy: changes
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-15 15:17:37 +02:00
DL6ER
6f7e1b5b59 Open Query Log with filtering option on Query Type when left-clicking on an element in the pie-chart. The current behavior is moved to middle mouse click.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-15 14:33:02 +02:00
Mark Drobnak
da2a6fec69 Merge pull request #817 from pi-hole/codeformatting
Changes to code formatting
2018-08-13 16:11:28 -04:00
Rob Gill
5dfe0eedef Standalone open curly brackets for if and for statements
For code consistency all opening curly brackets for if and for statements now stand alone on their own lines

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
2018-08-11 09:26:58 +10:00
Rob Gill
32cd50b718 Changes to formatting only (no functional changes)
Issues identified by codacy

*Multiple spaces removed
*piholeChanged defined before use
*curly brackets after if conditions
*lonely if converted to else if

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
2018-08-11 08:29:03 +10:00
Rob Gill
ff29a440b5 Double quotes.
i <3 codacy-bot

Signed-Off-By: Rob Gill <rrobgill@protonmail.com>
2018-08-10 13:39:14 +10:00
Rob Gill
ad2439c46d Adjust customToolTips to deal with pie charts
Signed-Off-By: Rob Gill <rrobgill@protonmail.com>
2018-08-10 13:16:46 +10:00
Rob Gill
4cf14dfc30 Constrain tooltips for piecharts
This stops the tooltips from disappearing beyond the pie chart's canvas.

Signed-Off-By: Rob Gill <rrobgill@protonmail.com>
2018-08-10 09:59:31 +10:00
Mcat12
dd77a6af58 Add missing semicolon
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-15 16:43:14 -04:00
Mcat12
846e3e4184 Fix lag by limiting rendering to every 50ms
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-15 15:04:38 -04:00
Mcat12
4542a68f2f Fix y value of tooltip scaling incorrectly
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-15 15:04:07 -04:00
DL6ER
2aef235040 Use client address if name is empty
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-06-07 19:05:27 +02:00
Mcat12
357da1d15a Expose both name and IP of client
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-06-06 18:27:55 -04:00
DL6ER
2eb4f78e0d Merge pull request #744 from pi-hole/fix/show_blocked_permitted_only
Correctly apply API_QUERY_LOG_SHOW filters on dashboard
2018-05-29 15:24:36 +02:00
Mark Drobnak
75559ef86e Merge pull request #759 from pi-hole/fix/getClientNames
Fix a minor bug in api.php?getClientNames
2018-05-28 14:36:53 -04:00
DL6ER
b2743ed245 Fix a minor bug with api.php?getClientNames when hostnames are present more than once on the local network (maybe once IPv6, once IPv4)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-28 17:42:11 +02:00
DL6ER
c6f5c2ee35 Display new dns_queries_all_types value (if available)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-25 09:53:30 +02:00
DL6ER
62f349b996 Top Clients (blocked): Compute frequency relative to number of blocked not total number of queries
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-10 15:29:38 +02:00
DL6ER
0d283bbfa2 Address codacy issues
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-10 15:26:44 +02:00
DL6ER
d42784be8c Address codacy issues
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-10 15:22:00 +02:00
DL6ER
73df3bddb6 Add "Top Clients (blocked only)" table
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-10 15:11:22 +02:00
DL6ER
fd3a7d3f57 Don't return too early when filling tables with top domains/top ads data. Otherwise, we might miss to remove the loading spinners. This fixes an issue brought up on Discourse.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-09 18:39:29 +02:00
DL6ER
5f3f105387 Add frontend changes necessary for https://github.com/pi-hole/FTL/pull/264
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-28 23:09:54 +02:00
Adam Warner
c414a4aba1 Merge branch 'devel' into FTLDNS 2018-04-14 00:53:23 +01:00
Adam Warner
b09de8e615 Fix merge conflict
Signed-off-by: Adam Warner <adamw@rner.email>
2018-04-14 00:43:27 +01:00
Adam Warner
2be54bc17a Prevent tooltip from being hidden by sidebar 2018-04-14 00:37:04 +01:00
DL6ER
081afa4924 Remove clients over time graph if no data is returned (privacy mode!)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-04 14:24:59 +02:00
DL6ER
634fa7f2b3 Remove top clients table if no data is returned (privacy mode!)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-04 14:22:35 +02:00
Mcat12
7244e3a9e0 Don't search for the element by ID when we already have it
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-04-02 17:43:19 -04:00
DL6ER
4cf0f4d6ff Make sure the properties exist when looping over objects
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-02 22:29:38 +02:00
DL6ER
e5e956ace6 Automatically detect which _meta to use
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-02 22:07:07 +02:00
DL6ER
8b2e7b89ac Add separate legends for pie charts on the dashboard. Fixes #635
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-02 14:36:21 +02:00
DL6ER
5aba5a1314 Add missing semicolon
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-25 18:49:15 +02:00
DL6ER
27d40465cd Use jQuery's .html() routine to overwrite element's content
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-25 18:48:23 +02:00
DL6ER
7bf5207e06 Fix JS error
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-25 18:39:03 +02:00
DL6ER
2aca7bf764 customTooltips must be defined before used
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-25 14:00:02 +02:00
DL6ER
062ba5141b Strings must use doublequote
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-25 11:32:36 +02:00
DL6ER
44774d914c We should split the string at ": " instead of at ":" to be fully compatible with IPv6 addresses
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-25 10:20:26 +02:00
DL6ER
e3cd76ad7d Add simple measure to prevent compression of the tooltip at the right edge of the screen (may be improved, not tested on mobile screens)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-20 16:50:53 +01:00
DL6ER
b6be5629ac Show only non-zero entries
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-20 15:28:39 +01:00
DL6ER
a5ca08c84d Add custom tooltip as suggested by user @kh0505 here: https://github.com/pi-hole/AdminLTE/issues/603#issuecomment-373933097
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-03-20 15:20:09 +01:00