Commit Graph

74 Commits

Author SHA1 Message Date
XhmikosR
ea1fd6c323 Remove HTML from titles when not needed.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-06-22 08:53:48 +03:00
Adam Warner
c949516ee1 make use of utils.escapeHtml on the JS side of things, and html_entity_decode/htmlentities in PHP
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-06-13 18:50:36 +01:00
Adam Warner
7aa79a7a77 Merge pull request #1420 from pi-hole/tweak/improve_warnings
Improve messages on the domain management pages
2020-06-05 19:17:17 +01:00
DL6ER
4bf018b52c Add missing radix information in parseInt().
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 16:57:55 +02:00
DL6ER
332cff1d36 Improve warnings on the domain management pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-02 11:37:23 +02:00
XhmikosR
cecb5aa88c Use $(fn)
This is the recommended way in jQuery 3.x.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-30 10:24:55 +03:00
XhmikosR
f04647fc9e Ignore the remaining console errors for now.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-29 10:42:21 +03:00
Adam Warner
39ac2026b0 Check data for null before trying to manipulate it. Closes #1391
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-28 21:38:14 +01:00
DL6ER
184c8e47e1 Merge pull request #1332 from pi-hole/tweak/dhcp_save_state
Remember last used sort column/direction on DHCP lease tables
2020-05-25 20:05:45 +02:00
XhmikosR
e70e108cce Use .hidden/.show for showing/hiding the reset buttons
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 13:04:13 +03:00
Adam Warner
3957e9eef1 Move some duplicated code to utils.js
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-23 11:04:30 +03:00
XhmikosR
4247c973c9 Rename function.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 10:29:50 +03:00
XhmikosR
0fa7de82b0 JS: Enforce camelcase.
It's a common convention to use camelcase for variable names.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 10:29:44 +03:00
XhmikosR
f2b11caf58 Rename variable to camelcase.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-17 08:53:53 +03:00
DL6ER
6b8e12a0d1 Fix autocomplete bug on group pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-13 23:54:22 +02:00
XhmikosR
43151d3c43 Add type="button" to all buttons.
The default is `type="submit"`.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 21:40:26 +03:00
XhmikosR
e02df5467a Fix lint errors.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 09:20:32 +03:00
DL6ER
73ee91a024 Merge branch 'master' into master-to-development-v5.0
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-10 22:00:07 +02:00
XhmikosR
bdde1e6667 Use text() when retrieving the token. (#1237)
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-04 10:52:00 +03:00
XhmikosR
ae13014565 Adapt to the new rules.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-04-10 18:34:47 +00:00
DL6ER
a64810e00e Merge branch 'release/v5.0' into devel
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-08 12:25:18 +02:00
DL6ER
43b45d3da7 Merge pull request #1100 from Ghalid/patch-1
Disable text correction features, change types to make input fields easier to type in (especially for mobile devices)
2020-04-07 13:59:44 +02:00
Th3M3
3ea59d5d36 shorter button textes & cleanup
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-05 20:49:53 +02:00
Th3M3
fd983a2b68 improve multiselect
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-05 14:56:28 +02:00
DL6ER
bc9c656e37 Improve domain pages (#1184)
* Split domain input into two separate fields.

* Codestyle changes

* Fix checkout layout on full/limited domain pages.

* Improve wildcard hint

Signed-off-by: DL6ER <dl6er@dl6er.de>


* tabs for new domain/regex input

Signed-off-by: Th3M3 <the_me@outlook.de>


Co-authored-by: TheME <andreas_fl@outlook.com>
2020-03-15 12:07:22 -07:00
Dan Schaper
aa51f014ab Fix domain and group disassociation when toggling from Black/Whitelis… (#1172)
* Fix domain and group disassociation when toggling from Black/Whitelist page

* Properly set the groups variable

Signed-off-by: trillaxe <trillax@tutanota.com>

* Trim whitespace

Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2020-03-05 12:59:42 -08:00
TheME
9fde58d7e0 make id names unique, ...* (#1170)
* - remove unneeded code
- fix php notice in log if url parameter 'type' is not set

Signed-off-by: Th3M3 the_me@outlook.de
2020-02-21 12:04:51 -08:00
Adam Warner
596f5af7fa Merge branch 'release/v5.0' into fix/group_assignment_allow_overflow 2020-02-16 18:51:29 +00:00
Adam Warner
211bcc999f Whejn dropdown is shown, move it outside of the datatable container (at the same absolute position)
When it is closed, put it back where it came from

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-02-16 17:33:52 +00:00
Adam Warner
a7a99ea693 update multiselects on other group pages with the same logic
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-02-16 16:10:14 +00:00
DL6ER
0c1f3b3d14 Depend display of group assigmnent delect field on number of visible columns.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-16 08:00:03 +01:00
DL6ER
ef57abdbdd Enhance wrapping for long regex lines on the domains list pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-16 07:59:07 +01:00
DL6ER
2d975b8bac Simplify domain management by using the same page for both locations where domains can be edited. This removes a large amount of duplicated code, each prone to its own bugs.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-14 20:31:54 +01:00
Adam Warner
519e2771f1 Merge pull request #1124 from pi-hole/master-xmr-fa
Switch to using Font Awesome
2020-02-08 12:31:07 +00:00
DL6ER
ea3ea19bc3 Merge branch 'release/v5.0' into new/CNAME_inspection_details
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-02-04 07:47:45 +01:00
DL6ER
a97f52ad76 Add possibility to highlight line on the Groups Domain Management page with specifying the domainid as GET parameter.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-01-30 21:03:25 +00:00
DL6ER
516c9e946a Add utils object for common code.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-01-27 11:21:02 +00:00
DL6ER
cfec7412da Merge branch 'release/v5.0' into tweak/groups_mgmt_disable_controls 2020-01-27 10:52:14 +00:00
DL6ER
88da85f553 Add responsive design to new group tables to ensure they render properly on very narrow screens. (#1137)
Signed-off-by: DL6ER <dl6er@dl6er.de>

Co-authored-by: Dan Schaper <dan@glacialmagma.com>
2020-01-25 17:46:38 -08:00
DL6ER
43a861a6a9 Disable form elements while database operation is pending.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-01-22 19:51:48 +01:00
Ghalid
d93f1a22cb Remove autocorrect in search boxes on groups
Signed-off-by: Ghalid <24234921+Ghalid@users.noreply.github.com>
2020-01-19 13:12:57 -05:00
XhmikosR
dee16f6c7a Switch to using Font Awesome
This should be more consistent.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-01-19 13:53:48 +02:00
XhmikosR
0f0820dae4 Use text() for token.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-01-19 13:49:46 +02:00
XhmikosR
b74f0f3969 Fix the remaining lint issues
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-01-02 19:42:19 +02:00
XhmikosR
704c352277 Format JS code
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-01-02 19:42:18 +02:00
Adam Warner
fe45538fc2 Merge pull request #1111 from pi-hole/license-headers
Add license headers.
2020-01-02 17:28:31 +00:00
XhmikosR
2c315cec4a Add license headers.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-29 10:08:31 +02:00
XhmikosR
e91d0b0cfa Switch back to var
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-29 10:07:01 +02:00
DL6ER
9b7daa324a Do not go back to page 1 when deleting an item.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-28 13:21:53 +00:00
DL6ER
b840d2103b Do not reload table on successfull edits and deletions.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-23 15:38:59 +00:00