Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2025-12-21 11:18:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,377 Commits 19 Branches 112 Tags
c6fbdfcdffcd5145bffe6deaed03d9220a686c59
Commit Graph

93 Commits

Author SHA1 Message Date
DL6ER
b48652ad82 Fix group editing 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2024-01-06 09:28:32 +01:00
DL6ER
10ca38da47 Use new special POST :batchDelete callbacks for /api/groups, /api/domains/, /api/clients, and /api/lists and remove some code duplication along the way. Also ensure that the "Default" group cannot be selected for deletion (we already suppress the trash button for this entry) 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-12-07 19:00:59 +01:00
DL6ER
a39c8a5c0a Escape only where we are displaying 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-11-18 22:38:01 +01:00
DL6ER
bc1c6bc117 Explicitly set contentType to avoid promotion to jsonp 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-11-18 12:54:41 +01:00
DL6ER
4d3c0cded9 Fix errors happening when editing groups/clients/domains/lists not being shown. Also fix logic of the strings "enabling/disabling" as the variable "enabled" already has the new (not the current state). This was correct in groups.js, but not the others 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-11-05 21:54:40 +01:00
DL6ER
402017798e Merge branch 'development-v6' into tweak/domain_array 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-10-14 16:23:31 +02:00
DL6ER
43c8ede674 Add "processData: false" to all JSON data we send 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-10-13 09:44:01 +02:00
DL6ER
1146248964 Revert "Fix AJAX JSON data (#2742)" 
This reverts commit 340d373711, reversing
changes made to 1ed1efdc91.

Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-10-13 09:41:10 +02:00
DL6ER
d2701f7955 We should not use JSON.stringify() but leave escaping to AJAX itself 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-10-10 19:28:14 +02:00
DL6ER
d516aec5ce Give details about sucessfully added and failed items to domains, groups, lists and clients 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-10-08 10:56:45 +02:00
DL6ER
a6ba2a8eb8 Implement support for adding multiple domains, clients, groups, and list addresses at once 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-10-07 21:38:10 +02:00
RD WebDesign
ef513c2c48 Fix previous spellcheck errors 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2023-06-30 20:35:34 -03:00
DL6ER
4d3d64b904 Ported groups-domains.lp and groups-adlists.lp 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-05-06 20:07:26 +02:00
DL6ER
f3d7eb296a Ported groups-clients.lp 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-05-06 07:27:37 +02:00
DL6ER
8a794ca69b Ported groups.lp 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2023-05-05 14:05:50 +02:00
Christian König
4473955291 Don't use idstring in messages when it's not necessary 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-01-20 16:57:34 +01:00
Christian König
acac90f79d Tweak deleting message 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-01-20 16:57:34 +01:00
Joshua Wu
b6963a8eb1 Add auto focus to groups and groups-adlist pages 
Signed-off-by: Joshua Wu <Joshua.wu.0910@gmail.com>
 2022-08-24 16:50:22 -07:00
RD WebDesign
f0bd5d725e Fixing minor inconsistencies 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2022-05-07 15:37:39 -03:00
RD WebDesign
a2cb6821dc Fixing weird bug 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2022-05-07 00:30:07 -03:00
RD WebDesign
89fdc7ed1c Remove unused variable 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2022-04-30 16:10:25 -03:00
RD WebDesign
a4bd5d0d90 Quote SQL reserved word and fix javascript output. 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2022-04-30 16:08:02 -03:00
RD WebDesign
67cece627d Fix data.columns ID replaced by mistake 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2022-04-30 15:16:11 -03:00
RD WebDesign
9a019a64ee Applying the reviewer's suggestions 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2022-04-30 14:34:22 -03:00
RD WebDesign
f8ab31f431 Allow delete multiple items - Group pages 
- add checkboxes, buttons and functions to groups page;
- add checkboxes, buttons and functions to clients page;
- add checkboxes, buttons and functions to domains page;
- add checkboxes, buttons and functions to adlists page;
- move function to `utils.js`;
- fix CSS after insert a new table column;

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2022-04-22 22:22:03 -03:00
Christian König
01de8fa3a8 Add navigation above all datatables 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2022-02-06 21:47:44 +01:00
RD WebDesign
035d8f981d Fix layout on small screens (Group Mgmt tables) (#2078) 
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
 2022-01-14 22:41:41 +01:00
Christian König
78aace3403 Revert "Remove duplicated code as it is already part of utils.stateLoadCallback" 
This reverts commit 395b1b6c1f.

Signed-off-by: Christian König <ckoenig@posteo.de>
 2021-11-14 22:38:18 +01:00
yubiuser
5aeb52ee50 Merge pull request #1948 from pi-hole/tweak/datatables 
Tweak to datatables column rendering
 2021-10-28 20:21:01 +02:00
yubiuser
98ec9ee2fc Set stateDuration to 0 for all saved datatables to store the state indefinitely (#1944) 
* Set stateDuration to 0 for all saved datatables to store the state indefinite

Signed-off-by: Christian König <ckoenig@posteo.de>

* Move stateDuration to utils.js

Signed-off-by: Christian König <ckoenig@posteo.de>

* Remove duplicated code as it is already part of utils.stateLoadCallback

Signed-off-by: Christian König <ckoenig@posteo.de>

* Fix function

Signed-off-by: Christian König <ckoenig@posteo.de>

* Revert "Fix function"

This reverts commit 2f54f5f988.

Signed-off-by: Christian König <ckoenig@posteo.de>

* Revert "Move stateDuration to utils.js"

This reverts commit 6a3e7786bc.

Signed-off-by: Christian König <ckoenig@posteo.de>
 2021-10-27 20:06:02 +01:00
Adam Warner
0e483a8eea Force all columns in any declared datatable to render using datatables render.text function to prevent possible (very low risk, requiring authenticated dashboard anyway) XSS. 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
 2021-10-27 19:49:46 +01:00
DL6ER
0d0a8dba67 Change prettier option trailingComma from "none" to the new default "es5" (see https://prettier.io/docs/en/options.html#trailing-commas) 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2021-06-23 11:26:43 +02:00
Adam Warner
638a7db036 Merge pull request #1603 from thislooksfun/devel 
Fix html escaping showing up in input fields. (#1584)
 2020-11-08 15:40:04 +00:00
Adam Warner
dc5df4eefa Merge pull request #1600 from rickbau5/fix/enable-ui-elements 
Fix UI Remaining Disabled in Groups & Adlists Pages
 2020-11-08 15:21:58 +00:00
Adam Warner
280d31c00f Merge branch 'devel' into fix/group_sel_simple_pages 2020-11-08 13:57:52 +00:00
thislooksfun
8f55dfa03b Fix html escaping showing up in input fields. (#1584) 
Signed-off-by: thislooksfun <thislooksfun@repbot.org>
 2020-10-12 12:26:49 -05:00
Rick Boss
197592a97c Ensure UI is reenabled in missed error cases 
Signed-off-by: Rick Boss <rickeboss@gmail.com>
 2020-10-07 22:47:30 -07:00
XhmikosR
ea1fd6c323 Remove HTML from titles when not needed. 
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
 2020-06-22 08:53:48 +03:00
Adam Warner
c949516ee1 make use of utils.escapeHtml on the JS side of things, and html_entity_decode/htmlentities in PHP 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
 2020-06-13 18:50:36 +01:00
XhmikosR
cecb5aa88c Use $(fn) 
This is the recommended way in jQuery 3.x.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
 2020-05-30 10:24:55 +03:00
XhmikosR
f04647fc9e Ignore the remaining console errors for now. 
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
 2020-05-29 10:42:21 +03:00
Adam Warner
39ac2026b0 Check data for null before trying to manipulate it. Closes #1391 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
 2020-05-28 21:38:14 +01:00
DL6ER
7214a0f025 Fix initial visibility of group selector on simplified black- and whitelist pages. 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2020-05-26 23:18:08 +02:00
DL6ER
184c8e47e1 Merge pull request #1332 from pi-hole/tweak/dhcp_save_state 
Remember last used sort column/direction on DHCP lease tables
 2020-05-25 20:05:45 +02:00
XhmikosR
e70e108cce Use .hidden/.show for showing/hiding the reset buttons 
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
 2020-05-23 13:04:13 +03:00
Adam Warner
3957e9eef1 Move some duplicated code to utils.js 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
 2020-05-23 11:04:30 +03:00
XhmikosR
0fa7de82b0 JS: Enforce camelcase. 
It's a common convention to use camelcase for variable names.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
 2020-05-23 10:29:44 +03:00
DL6ER
6b8e12a0d1 Fix autocomplete bug on group pages. 
Signed-off-by: DL6ER <dl6er@dl6er.de>
 2020-05-13 23:54:22 +02:00
XhmikosR
43151d3c43 Add type="button" to all buttons. 
The default is `type="submit"`.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
 2020-05-11 21:40:26 +03:00
XhmikosR
bdde1e6667 Use text() when retrieving the token. (#1237) 
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
 2020-05-04 10:52:00 +03:00