Commit Graph

283 Commits

Author SHA1 Message Date
XhmikosR
704c352277 Format JS code
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-01-02 19:42:18 +02:00
Adam Warner
4fbec2a557 Merge pull request #1112 from pi-hole/scrollY
`window.scrollY` isn't supported on IE
2020-01-02 17:34:02 +00:00
Adam Warner
ab629c52a1 Replace padStart with a solution that works in older browsers
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2019-12-29 10:17:55 +02:00
XhmikosR
6e55b4f827 window.scrollY isn't supported on IE
Replace it with `window.pageYOffset`

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-29 10:12:09 +02:00
DL6ER
1849e8a9c6 Remove unused variable.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-19 15:45:37 +00:00
DL6ER
aca6461468 Change over-time graphs from line to stacked bar representation. This is much more natural for this kind of data. Also, improve DB graphs to always generate a meaningful display (always generate about 200 bars). This graph was basically unusable when specifying a larger range than, say, one week.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-18 13:22:33 +00:00
DL6ER
f9496c5c6e Merge pull request #1087 from pi-hole/let
Use var instead of let.
2019-12-17 15:54:01 +01:00
XhmikosR
18cfd8dab1 Reuse variable and make code clearer
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 12:19:43 +02:00
XhmikosR
ef396ede5b Use var instead of let.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-17 10:47:01 +02:00
XhmikosR
9c1846885a Clean up JS
* remove unused variables/functions
* use the dot notation
* use explicit coercion
* remove unneeded else
* use `textContent` instead of `innerHTML`
* cache a few `getElementById` calls
* fix a couple of undefined variables
* various assorted lint tweaks

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-16 20:36:40 +02:00
XhmikosR
7031d19d25 Remove unneeded escape characters
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-09 21:50:42 +02:00
XhmikosR
d65b5be5e2 A few CSS tweaks.
Add utilities classes and fix a few CSS issues.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-09 21:36:58 +02:00
XhmikosR
5275faacb1 Lowercase hex colors.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-09 16:53:21 +02:00
Adam Warner
a9852b8762 Merge pull request #1064 from XhmikosR/patch-4
Remove unused variables
2019-12-08 14:31:16 +00:00
XhmikosR
37c849ce2b Remove unused variables
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2019-12-07 11:49:49 +02:00
DL6ER
ac4a1d0a61 Remove more dead code
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-12-04 20:46:08 +00:00
DL6ER
0cf3934b87 Merge branch 'patch-1' of https://github.com/WaLLy3K/AdminLTE into WaLLy3K-patch-1 2019-12-04 20:43:20 +00:00
DL6ER
858a916dcb Top Clients (blocked only) tooltip should show total number of blocked queries. The percentage is already computed correctly.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-11-02 11:07:43 +01:00
DL6ER
df6fd5e1c4 Use correct IDs for spinners in index.js
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-08-27 16:56:42 +02:00
WaLLy3K
ca4130743a Remove updateQueryTypesOverTime call
Remove call as per #915, which may cause issues with the dashboard not loading stats.

Signed off by WaLLy3K <w3k@pm.me>
2019-06-30 22:17:13 +10:00
DL6ER
d616a1180a Check data before converting. This allows us to detect if there is no data for the graph so we can hide it. Fixes #932
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-06-15 17:20:49 +02:00
DL6ER
635bdfb717 Undo removal of slice operations
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-17 11:52:14 +01:00
DL6ER
e433e90308 Remove dead code from scripts/pi-hole/js/index.js
Removed:
- updateForwardedOverTime();
- updateQueryTypesOverTime();
- slicing on overTime data

Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-11 00:52:24 +01:00
DL6ER
56251d1808 Forward destinations -> Upstreams
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-09-24 12:55:55 +02:00
Mark Drobnak
d7b328e103 Use doublequote strings and add comment
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com>
2018-08-16 17:47:05 -04:00
Mark Drobnak
6af8c76c3f Use random colors in client graph if presets run out
Signed-off-by: Mark Drobnak <newtoncat12@yahoo.com>
2018-08-16 17:38:02 -04:00
DL6ER
55969fab4b A = 1, AAAA = 2, ...
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-15 15:20:27 +02:00
DL6ER
a72dbd8f91 :codacy: changes
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-15 15:17:37 +02:00
DL6ER
6f7e1b5b59 Open Query Log with filtering option on Query Type when left-clicking on an element in the pie-chart. The current behavior is moved to middle mouse click.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-15 14:33:02 +02:00
Mark Drobnak
da2a6fec69 Merge pull request #817 from pi-hole/codeformatting
Changes to code formatting
2018-08-13 16:11:28 -04:00
Rob Gill
5dfe0eedef Standalone open curly brackets for if and for statements
For code consistency all opening curly brackets for if and for statements now stand alone on their own lines

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
2018-08-11 09:26:58 +10:00
Rob Gill
32cd50b718 Changes to formatting only (no functional changes)
Issues identified by codacy

*Multiple spaces removed
*piholeChanged defined before use
*curly brackets after if conditions
*lonely if converted to else if

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
2018-08-11 08:29:03 +10:00
Rob Gill
ff29a440b5 Double quotes.
i <3 codacy-bot

Signed-Off-By: Rob Gill <rrobgill@protonmail.com>
2018-08-10 13:39:14 +10:00
Rob Gill
ad2439c46d Adjust customToolTips to deal with pie charts
Signed-Off-By: Rob Gill <rrobgill@protonmail.com>
2018-08-10 13:16:46 +10:00
Rob Gill
4cf14dfc30 Constrain tooltips for piecharts
This stops the tooltips from disappearing beyond the pie chart's canvas.

Signed-Off-By: Rob Gill <rrobgill@protonmail.com>
2018-08-10 09:59:31 +10:00
Mcat12
dd77a6af58 Add missing semicolon
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-15 16:43:14 -04:00
Mcat12
846e3e4184 Fix lag by limiting rendering to every 50ms
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-15 15:04:38 -04:00
Mcat12
4542a68f2f Fix y value of tooltip scaling incorrectly
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-07-15 15:04:07 -04:00
DL6ER
2aef235040 Use client address if name is empty
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-06-07 19:05:27 +02:00
Mcat12
357da1d15a Expose both name and IP of client
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-06-06 18:27:55 -04:00
DL6ER
2eb4f78e0d Merge pull request #744 from pi-hole/fix/show_blocked_permitted_only
Correctly apply API_QUERY_LOG_SHOW filters on dashboard
2018-05-29 15:24:36 +02:00
Mark Drobnak
75559ef86e Merge pull request #759 from pi-hole/fix/getClientNames
Fix a minor bug in api.php?getClientNames
2018-05-28 14:36:53 -04:00
DL6ER
b2743ed245 Fix a minor bug with api.php?getClientNames when hostnames are present more than once on the local network (maybe once IPv6, once IPv4)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-28 17:42:11 +02:00
DL6ER
c6f5c2ee35 Display new dns_queries_all_types value (if available)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-25 09:53:30 +02:00
DL6ER
62f349b996 Top Clients (blocked): Compute frequency relative to number of blocked not total number of queries
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-10 15:29:38 +02:00
DL6ER
0d283bbfa2 Address codacy issues
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-10 15:26:44 +02:00
DL6ER
d42784be8c Address codacy issues
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-10 15:22:00 +02:00
DL6ER
73df3bddb6 Add "Top Clients (blocked only)" table
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-10 15:11:22 +02:00
DL6ER
fd3a7d3f57 Don't return too early when filling tables with top domains/top ads data. Otherwise, we might miss to remove the loading spinners. This fixes an issue brought up on Discourse.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-09 18:39:29 +02:00
DL6ER
5f3f105387 Add frontend changes necessary for https://github.com/pi-hole/FTL/pull/264
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-28 23:09:54 +02:00