Commit Graph

96 Commits

Author SHA1 Message Date
Mcat12
c5b25f23e5 Add missing break
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-07-09 20:37:05 -07:00
Mcat12
bc85bcda7b Prevent static DHCP leases from having duplicate hostnames
Fixes #979

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-07-09 20:35:15 -07:00
Mcat12
86ba703ef5 Use the renamed adlist table when getting adlists
This fixes an error shown on the settings page.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-07-04 11:28:01 -07:00
Mark Drobnak
4e1df1664c Merge pull request #951 from pi-hole/new/arp-flush
Add button for pihole arpflush on Pi-hole settings page
2019-07-04 14:10:29 -04:00
Mcat12
f7905167c0 Prevent command injection via admin email
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-07-01 20:17:10 -07:00
DL6ER
43fa24fbea Glue needs to be the first argument of implode
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-05-30 22:11:13 +02:00
DL6ER
72abc5dad4 Add button for pihole arpflush on Pi-hole settings page
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-05-30 22:05:13 +02:00
DL6ER
ced7174c37 Modify adlists subpage of the settings page to sources the lists from the gravity database.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-04-28 20:42:50 +02:00
Mcat12
2ba8787261 Merge branch 'release/v4.2' into devel
# Conflicts:
#	scripts/pi-hole/js/db_graph.js
2019-02-03 11:24:19 -08:00
Mark Drobnak
991be959d3 Update scripts/pi-hole/php/savesettings.php
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com>
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-01-19 22:35:12 +01:00
Michael Epstein
84f6f3dae6 - Fix the delete of blacklist/whitelist records under NGINX + PHP-FPM
- Fix multiple php warning/error messages when this scripts are executed from AJAX requests

Example errors/warnings:

2019/01/15 13:22:22 [error] 1408#1408: *2535 FastCGI sent in stderr: "PHP message: PHP Notice:  Undefined variable: api in /var/www/html/admin/scripts/pi-hole/php/sub.php on line 16
PHP message: PHP Warning:  Cannot modify header information - headers already sent by (output started at /var/www/html/admin/scripts/pi-hole/php/sub.php:8) in /var/www/html/admin/scripts/pi-hole/php/auth.php on line 81
PHP message: PHP Warning:  session_start(): Cannot start session when headers already sent in /var/www/html/admin/scripts/pi-hole/php/auth.php on line 93

Signed-off-by: Michael Epstein <mepstein@mediabox.cl>
2019-01-16 01:51:54 -03:00
DL6ER
a10f23b79a Prevent multiple static DHCP entries for the same IP address to get added. Fixes #889
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-01-15 17:17:34 +01:00
Sylvia van Os
525901e552 Read DNS server list from file
Signed-off-by: Sylvia van Os <sylvia@hackerchick.me>
2019-01-13 19:49:49 +01:00
Dan Schaper
798486b7a3 Merge pull request #879 from pi-hole/hotfix/v4.1.1
Merge hotfix v4.1.1 into dev
2018-12-21 09:07:21 -08:00
Dan Schaper
a0961f9e21 Cloudflare does not support ECS
>EDNS Client Subnet
1.1.1.1 is a privacy centric resolver so it does not send any client IP information and does not send the EDNS Client Subnet Header to authoritative servers.

https://developers.cloudflare.com/1.1.1.1/nitty-gritty-details/
2018-12-18 18:16:58 -08:00
Mark Drobnak
9fa4cc62cb Merge pull request #872 from pi-hole/release/v4.1
Update development with final v4.1 changes
2018-12-09 22:14:30 -05:00
Mark Drobnak
064e652344 Merge branch 'release/v4.1' into fix/admin-email-security 2018-12-06 12:18:39 -05:00
DL6ER
18f9ed4532 Update savesettings.php
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-11-26 19:12:08 +01:00
Mcat12
13c29336b2 Prevent possible attacks via admin email setting
The admin email is now treated as a single string (surrounded by single
quotes), and it is not allowed to contain its own single quotes.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-11-23 14:35:43 -05:00
DL6ER
ba11c7b394 Disply that the privacy level wasn't changed when this is the case.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-11-10 08:40:05 +01:00
DL6ER
8c08ec2a10 Automatically restart DNS resolver when privacy level is lowered
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-11-10 08:38:55 +01:00
Mark Drobnak
f612e51f15 Merge pull request #852 from bitcynth/patch-1
Error handling in savesettings.php
2018-11-07 18:03:38 -05:00
Cynthia
34bbb9a70e Error handling in savesettings.php
This is to address https://github.com/pi-hole/pi-hole/issues/2444

Signed-off-by: Cynthia Revstrom <me@cynthia.re>
2018-10-03 02:28:27 +02:00
DL6ER
6441a675c5 Add Quad9 secondary IPv6 IP addresses. This was a feature request on Discourse.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-31 12:48:25 +02:00
DL6ER
9a950147c4 Add explanation what ECS is as we shouldn't use acronyms without explaining them. Further, this information may be useful for less tech-savvy users.
Add that (at least) Google, OpenDNS, and Cloudflare use ECS (according to http://www.afasterinternet.com/participants.htm). I found no reference for the other providers in the table.

Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-30 17:56:11 +02:00
DL6ER
a2ade60cea Add more detailed selections for the services offered by Quad9 and improve responsive design
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-30 17:35:47 +02:00
Mcat12
78ae865d62 Add support for privacy level 4 (no stats)
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2018-08-20 17:33:29 -04:00
DL6ER
2df4a0d052 Improve logic
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-08 21:17:10 +02:00
DL6ER
8b1313b864 Don't require adlists to start in "http". This also displays lists that start in e.g., "ftp://" or "file://" or without a protocol.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-08-08 12:06:59 +02:00
Kevin Kirsche
49d6feb4c3 Fix 579 | Add interface option for administrator email address (Redo of #757)
Signed-off-by: Kevin Kirsche <Kev.Kirsche@gmail.com>
2018-05-26 23:17:17 -04:00
DL6ER
bd25557469 Remove last traces of local custom port settings
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-04 22:11:50 +02:00
DL6ER
dd96847cc5 Remove local DNS with custom port field as it is superseeded by the more powerful custom 1/2/3/4 implementation
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-04 19:16:55 +02:00
DL6ER
6d8c3de5ba Support custom ports in the custom DNS server tab on the settings page
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-05-04 19:14:31 +02:00
DL6ER
4c91d65547 Make sure backend does always interpret list of DNS servers even if it is empty
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-19 07:38:34 +02:00
DL6ER
847d6aae53 Improve code as suggested
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-18 21:49:35 +02:00
DL6ER
7fa6cd85d3 Be less specific, as this feature can be used for any time of local resolver running on a custom port
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-18 17:31:16 +02:00
DL6ER
f2cefe6ce1 Add frontend changes for supporting a local recursive DNS server
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-18 17:11:36 +02:00
DL6ER
1055ccf4a3 Add privacy level tab to Settings page
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-04-04 14:20:19 +02:00
Everett Southwick
5e9c1aec9a Add support for public Cloudflare DNS servers.
Signed-off-by: Everett Southwick <everett@everettsouthwick.com>
2018-04-01 18:02:26 -05:00
Mark Drobnak
0f76158129 Merge pull request #653 from ryanknapper/devel
Conditional forwarding options
2018-02-18 12:51:57 -05:00
DL6ER
78f6cb3751 Add option to disable logging without flushing logs (for temporary disabling without wanting to nuke the logs).
Signed-off-by: DL6ER <dl6er@dl6er.de>
2018-01-18 17:09:20 +01:00
Mark Drobnak
34b6c37516 Fix IP check and allow host names in Top Clients filter
Signed-off-by: Mark Drobnak <newtoncat12@yahoo.com>
2018-01-11 15:33:31 -05:00
Mark Drobnak
323b3a7a8b Fix Top Clients filter
It expected IP addresses, but only let in domains

Signed-off-by: Mark Drobnak <newtoncat12@yahoo.com>
2018-01-10 15:56:41 -05:00
DL6ER
bc1f6f9be6 Add quad9 secondary IPv4 server
Signed-off-by: DL6ER <dl6er@dl6er.de>
2017-12-30 18:26:49 +01:00
ryanknapper
9b3cf91cee Update savesettings.php
Added section to save conditional forwarding settings.
2017-12-26 13:47:40 -05:00
Mcat12
c2d9506bec Merge pull request #619 from mcattle/patch-1
Add Quad9 DNS Servers to DNS Servers List
2017-11-18 14:06:51 -05:00
mcattle
edb93db3ce Add Quad9 DNS Servers to DNS Servers List
I've added the Quad9 DNS servers (IPv4 and IPv6) to the DNS Servers list.  (https://www.quad9.net/)  I've opted not to also add their non-secure alternate servers, as those mainly exist for diagnostics of false positives, and are not the primary focus of the Quad9 service.  They do not offer secondary servers, as their primary servers are already geographically distributed and redundant.
2017-11-16 23:08:35 -07:00
WaLLy3K
0bafeabe49 Allow full stop in top list wildcard exclusions
* Fix #580
2017-09-22 18:19:04 +10:00
DL6ER
5ab4430ef0 halt -> poweroff
Signed-off-by: DL6ER <dl6er@dl6er.de>
2017-09-08 20:30:59 +02:00
gedetil
08f40722c1 Update savesettings.php
Implement "Halt system" button, next to "Restart system" button, on
admin/settings page.  Useful for doing clean shutdown before powering off.

Gilbert Detillieux <gedetil> 2017-04-11
2017-04-11 13:44:18 -05:00