Commit Graph

100 Commits

Author SHA1 Message Date
Christian König
4473955291 Don't use idstring in messages when it's not necessary
Signed-off-by: Christian König <ckoenig@posteo.de>
2023-01-20 16:57:34 +01:00
Christian König
acac90f79d Tweak deleting message
Signed-off-by: Christian König <ckoenig@posteo.de>
2023-01-20 16:57:34 +01:00
Christian König
d55847013f Fix deprecated warnings of jquery-migrate
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-10-13 17:53:13 +02:00
RD WebDesign
4d8b19f4c9 Address team decisions
- change checkboxes order;
- remove all lines if all checkboxes are unselected.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-09-09 14:26:54 -03:00
RD WebDesign
3ef30992c5 Move filter selector to header-box
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-09-09 14:26:54 -03:00
RD WebDesign
3235056d31 Add the ability to filter domains by type
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-09-09 14:26:54 -03:00
Joshua Wu
a0417e92d1 Refocus the domain element after submitting new domain in list form
Signed-off-by: Joshua Wu <Joshua.wu.0910@gmail.com>
2022-08-24 16:50:21 -07:00
DL6ER
82d18b51a3 Further simplification of the code, removing empty code blocks and some always-true if-clauses
Signed-off-by: DL6ER <dl6er@dl6er.de>
2022-07-17 10:45:17 +02:00
Christian König
6a1e590a07 Remove black/whitelist from group pages
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-07-16 14:20:43 +02:00
Christian König
4c66e22260 Fix editing domains from blacklist/whitelist pages
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-07-11 10:19:53 +02:00
Anthony de Jong
eaef6f8733 Show suggested domains in group domains page
Signed-off-by: Anthony de Jong <11158888+anthony-de-jong@users.noreply.github.com>
2022-06-02 08:04:27 +00:00
RD WebDesign
f0bd5d725e Fixing minor inconsistencies
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-05-07 15:37:39 -03:00
RD WebDesign
a2cb6821dc Fixing weird bug
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-05-07 00:30:07 -03:00
RD WebDesign
9a019a64ee Applying the reviewer's suggestions
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-04-30 14:34:22 -03:00
RD WebDesign
f8ab31f431 Allow delete multiple items - Group pages
- add checkboxes, buttons and functions to groups page;
- add checkboxes, buttons and functions to clients page;
- add checkboxes, buttons and functions to domains page;
- add checkboxes, buttons and functions to adlists page;
- move function to `utils.js`;
- fix CSS after insert a new table column;

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2022-04-22 22:22:03 -03:00
Christian König
01de8fa3a8 Add navigation above all datatables
Signed-off-by: Christian König <ckoenig@posteo.de>
2022-02-06 21:47:44 +01:00
RD WebDesign
035d8f981d Fix layout on small screens (Group Mgmt tables) (#2078)
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
2022-01-14 22:41:41 +01:00
Christian König
78aace3403 Revert "Remove duplicated code as it is already part of utils.stateLoadCallback"
This reverts commit 395b1b6c1f.

Signed-off-by: Christian König <ckoenig@posteo.de>
2021-11-14 22:38:18 +01:00
yubiuser
5aeb52ee50 Merge pull request #1948 from pi-hole/tweak/datatables
Tweak to datatables column rendering
2021-10-28 20:21:01 +02:00
yubiuser
98ec9ee2fc Set stateDuration to 0 for all saved datatables to store the state indefinitely (#1944)
* Set stateDuration to 0 for all saved datatables to store the state indefinite

Signed-off-by: Christian König <ckoenig@posteo.de>

* Move stateDuration to utils.js

Signed-off-by: Christian König <ckoenig@posteo.de>

* Remove duplicated code as it is already part of utils.stateLoadCallback

Signed-off-by: Christian König <ckoenig@posteo.de>

* Fix function

Signed-off-by: Christian König <ckoenig@posteo.de>

* Revert "Fix function"

This reverts commit 2f54f5f988.

Signed-off-by: Christian König <ckoenig@posteo.de>

* Revert "Move stateDuration to utils.js"

This reverts commit 6a3e7786bc.

Signed-off-by: Christian König <ckoenig@posteo.de>
2021-10-27 20:06:02 +01:00
Adam Warner
0e483a8eea Force all columns in any declared datatable to render using datatables render.text function to prevent possible (very low risk, requiring authenticated dashboard anyway) XSS.
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2021-10-27 19:49:46 +01:00
DL6ER
0d0a8dba67 Change prettier option trailingComma from "none" to the new default "es5" (see https://prettier.io/docs/en/options.html#trailing-commas)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2021-06-23 11:26:43 +02:00
Adam Warner
638a7db036 Merge pull request #1603 from thislooksfun/devel
Fix html escaping showing up in input fields. (#1584)
2020-11-08 15:40:04 +00:00
Adam Warner
280d31c00f Merge branch 'devel' into fix/group_sel_simple_pages 2020-11-08 13:57:52 +00:00
thislooksfun
8f55dfa03b Fix html escaping showing up in input fields. (#1584)
Signed-off-by: thislooksfun <thislooksfun@repbot.org>
2020-10-12 12:26:49 -05:00
XhmikosR
ea1fd6c323 Remove HTML from titles when not needed.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-06-22 08:53:48 +03:00
Adam Warner
c949516ee1 make use of utils.escapeHtml on the JS side of things, and html_entity_decode/htmlentities in PHP
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-06-13 18:50:36 +01:00
Adam Warner
7aa79a7a77 Merge pull request #1420 from pi-hole/tweak/improve_warnings
Improve messages on the domain management pages
2020-06-05 19:17:17 +01:00
DL6ER
4bf018b52c Add missing radix information in parseInt().
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-04 16:57:55 +02:00
DL6ER
332cff1d36 Improve warnings on the domain management pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-06-02 11:37:23 +02:00
XhmikosR
cecb5aa88c Use $(fn)
This is the recommended way in jQuery 3.x.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-30 10:24:55 +03:00
XhmikosR
f04647fc9e Ignore the remaining console errors for now.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-29 10:42:21 +03:00
Adam Warner
39ac2026b0 Check data for null before trying to manipulate it. Closes #1391
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-28 21:38:14 +01:00
DL6ER
7214a0f025 Fix initial visibility of group selector on simplified black- and whitelist pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-26 23:18:08 +02:00
DL6ER
184c8e47e1 Merge pull request #1332 from pi-hole/tweak/dhcp_save_state
Remember last used sort column/direction on DHCP lease tables
2020-05-25 20:05:45 +02:00
XhmikosR
e70e108cce Use .hidden/.show for showing/hiding the reset buttons
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 13:04:13 +03:00
Adam Warner
3957e9eef1 Move some duplicated code to utils.js
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-05-23 11:04:30 +03:00
XhmikosR
4247c973c9 Rename function.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 10:29:50 +03:00
XhmikosR
0fa7de82b0 JS: Enforce camelcase.
It's a common convention to use camelcase for variable names.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-23 10:29:44 +03:00
XhmikosR
f2b11caf58 Rename variable to camelcase.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-17 08:53:53 +03:00
DL6ER
6b8e12a0d1 Fix autocomplete bug on group pages.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-13 23:54:22 +02:00
XhmikosR
43151d3c43 Add type="button" to all buttons.
The default is `type="submit"`.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 21:40:26 +03:00
XhmikosR
e02df5467a Fix lint errors.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-11 09:20:32 +03:00
DL6ER
73ee91a024 Merge branch 'master' into master-to-development-v5.0
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-05-10 22:00:07 +02:00
XhmikosR
bdde1e6667 Use text() when retrieving the token. (#1237)
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-05-04 10:52:00 +03:00
XhmikosR
ae13014565 Adapt to the new rules.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2020-04-10 18:34:47 +00:00
DL6ER
a64810e00e Merge branch 'release/v5.0' into devel
Signed-off-by: DL6ER <dl6er@dl6er.de>
2020-04-08 12:25:18 +02:00
DL6ER
43b45d3da7 Merge pull request #1100 from Ghalid/patch-1
Disable text correction features, change types to make input fields easier to type in (especially for mobile devices)
2020-04-07 13:59:44 +02:00
Th3M3
3ea59d5d36 shorter button textes & cleanup
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-05 20:49:53 +02:00
Th3M3
fd983a2b68 improve multiselect
Signed-off-by: Th3M3 <the_me@outlook.de>
2020-04-05 14:56:28 +02:00