Commit Graph

799 Commits

Author SHA1 Message Date
Mograine
ee7edb5fab Add feedback to users
Signed-off-by: Mograine <ghiot.pierre@gmail.com>
2019-11-27 00:40:43 +01:00
Mograine
192ad7ce8b Allow to use same Domain for IPv4/IPv6
Signed-off-by: Mograine <ghiot.pierre@gmail.com>
2019-10-28 13:18:08 +01:00
Mograine
820a92998e Remove unused var
Signed-off-by: Mograine <ghiot.pierre@gmail.com>
2019-10-27 16:48:39 +01:00
Pierre Ghiot
c44c5a7d32 Create customdns.js
Signed-off-by: Mograine <ghiot.pierre@gmail.com>
2019-10-27 16:48:39 +01:00
Pierre Ghiot
6326964226 Create customdns.php
Signed-off-by: Mograine <ghiot.pierre@gmail.com>
2019-10-27 16:48:39 +01:00
Pierre Ghiot
631f350a1e Update header.php
Signed-off-by: Mograine <ghiot.pierre@gmail.com>
2019-10-27 16:48:38 +01:00
Mark Drobnak
bfe7b76f34 Merge pull request #974 from pi-hole/fix/admin-email-validation
Prevent command injection via admin email
2019-09-12 21:11:19 -04:00
DL6ER
c399043db4 Use correct IDs for spinners in index.js
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:11:18 -04:00
DL6ER
e567983bb3 Change key: TEMPERATURELIMIT -> TEMPERATURE_LIMIT
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:11:17 -04:00
DL6ER
b66302bb9f Add TEMPERATURELIMIT setting in setupVars.conf for setting the level beyond which we show the temperature icon in red on the dashboard.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:11:14 -04:00
denny0754
01a29f6555 Fixed Issue#983 2019-09-12 21:11:13 -04:00
TheME
704f983243 remove unneeded class 'far'
Signed-off-by: Th3M3 <the_me@hotmail.de>
2019-09-12 21:11:13 -04:00
TheME
e816c28fd0 fix broken Icons
Signed-off-by: Th3M3 <the_me@hotmail.de>
2019-09-12 21:11:12 -04:00
Mcat12
580f1eb06d Add missing break
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-09-12 21:11:11 -04:00
Mcat12
fafd5b419b Prevent static DHCP leases from having duplicate hostnames
Fixes #979

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-09-12 21:11:10 -04:00
Daniel
f6aeac5a1c Improve audit logic to batch requests.
Signed-off-by: Daniel <daniel@developerdan.com>
2019-09-12 21:11:10 -04:00
Mcat12
964c54360b Don't show the "Click to ..." tooltip when filtering is disabled
Fixes #971

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-09-12 21:05:57 -04:00
DL6ER
a8b4cb74d8 Check data before converting. This allows us to detect if there is no data for the graph so we can hide it. Fixes #932
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:53 -04:00
DL6ER
c7aa2556a1 Add source URL to the JS file
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:50 -04:00
DL6ER
83013993cd Also show "N/A" if the name column is NULL
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:50 -04:00
DL6ER
a027715247 Move ip-address-sorting into its own file
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:49 -04:00
DL6ER
f830bfbc7b Add IP address sorting for the network table, based on https://datatables.net/plug-ins/sorting/ip-address
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:48 -04:00
DL6ER
c8086b4239 Check fields against null before trying to obtain their lengths.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:47 -04:00
DL6ER
19d6f4ae9f Move dataIndex definition into dataSrc function
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:46 -04:00
DL6ER
cdefb1ca60 Use Array.map() instead of looping over elements and pushing the content to a new array
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:45 -04:00
DL6ER
a4fe802fb9 Apply the same changes also for the database query list
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:44 -04:00
DL6ER
2175efd605 Use the render option of the columns definition to specify how and when the date string is shown.
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:44 -04:00
DL6ER
77931b499a Remove extra ID column, this is intentionally done in a separate commit
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:43 -04:00
DL6ER
695730920a Ensure correct sorting of queries even if they happened withing the same second. Fixes #934
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-09-12 21:05:42 -04:00
Adam Warner
0d0d44939d Set "orderable" to false on last column, as sorting does not work here!
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2019-05-02 21:58:14 +01:00
DL6ER
4923a7576c Remove another mentioning of data-mask
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-04-12 16:01:35 +02:00
DL6ER
a00e887930 Remove jQuery inputmask
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-04-10 17:12:35 +02:00
Mcat12
24a22bcb55 Fix security issue when using list functionality via api.php
Remote code execution could have been triggered by activating some list
functionality (add and remove) via api.php.

Thanks to Kacper Szurek for finding this bug.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-03-02 13:51:29 -08:00
Mark Drobnak
16d06d6948 Merge pull request #918 from pi-hole/new/fine_grained_externally_blocked_status
Long-term queries: Request all externally blocked variants when the checkbox is enabled
2019-02-22 21:53:24 -05:00
DL6ER
e0947d69ab Long-term queries: Request all externally blocked variants when the checkbox is enabled
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-22 21:26:36 +01:00
Mark Drobnak
e4d80b5e24 Merge pull request #909 from pi-hole/new/fine_grained_externally_blocked_status
Implement finer grained external blocking displaying
2019-02-17 14:14:49 -05:00
DL6ER
f728fd980d DNSSEC UNKNOWN is not an error, it is also shown for queries that are imported from the database
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-17 18:40:57 +01:00
DL6ER
635bdfb717 Undo removal of slice operations
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-17 11:52:14 +01:00
DL6ER
e433e90308 Remove dead code from scripts/pi-hole/js/index.js
Removed:
- updateForwardedOverTime();
- updateQueryTypesOverTime();
- slicing on overTime data

Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-11 00:52:24 +01:00
DL6ER
8796583818 Implement finer grained external blocking displaying
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-02-04 17:45:30 +01:00
Mcat12
2ba8787261 Merge branch 'release/v4.2' into devel
# Conflicts:
#	scripts/pi-hole/js/db_graph.js
2019-02-03 11:24:19 -08:00
DL6ER
adf44443b7 Merge branch 'release/v4.2' into fix/long-term-stats-datetime 2019-01-28 18:48:11 +01:00
Mcat12
f19a538e7f Clarify wording of DNSSEC Unknown status
Previously, unknown DNSSEC status was marked with a question mark. FTL
loads queries from the database and sets the DNSSEC status to unknown,
because that information is not stored in the database:
https://github.com/pi-hole/FTL/pull/461

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
2019-01-26 13:11:08 -08:00
DL6ER
a975576616 Long-term data: Show date range only after user chose a valid range. Fixes #897
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-01-22 23:30:36 +01:00
DL6ER
8ae36a0dcb Fill daterange field with initialization (now-6d -> now)
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-01-20 11:36:39 +01:00
Mark Drobnak
991be959d3 Update scripts/pi-hole/php/savesettings.php
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com>
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-01-19 22:35:12 +01:00
Michael Epstein
6447879562 Fix a PHP error generated by "Query Lists".
Example:
2019/01/18 00:56:46 [error] 19780#19780: *20783 FastCGI sent in stderr: "PHP message: PHP Notice:  ob_end_flush(): failed to delete and flush buffer. No buffer to delete or flush in /var/www/html/admin/scripts/pi-hole/php/queryads.php on line 9" while reading response header from upstream, client: xxx.xxx.xx.xx, server: some.server.lan, request: "GET /admin/scripts/pi-hole/php/queryads.php?domain=windows& HTTP/1.1", upstream: "fastcgi://unix:/run/php/pihole.sock:", host: "some.server.lan", referrer: "https://some.server.lan/admin/queryads.php"

Signed-off-by: Michael Epstein <mepstein@mediabox.cl>
2019-01-18 01:25:59 -03:00
Michael Epstein
84f6f3dae6 - Fix the delete of blacklist/whitelist records under NGINX + PHP-FPM
- Fix multiple php warning/error messages when this scripts are executed from AJAX requests

Example errors/warnings:

2019/01/15 13:22:22 [error] 1408#1408: *2535 FastCGI sent in stderr: "PHP message: PHP Notice:  Undefined variable: api in /var/www/html/admin/scripts/pi-hole/php/sub.php on line 16
PHP message: PHP Warning:  Cannot modify header information - headers already sent by (output started at /var/www/html/admin/scripts/pi-hole/php/sub.php:8) in /var/www/html/admin/scripts/pi-hole/php/auth.php on line 81
PHP message: PHP Warning:  session_start(): Cannot start session when headers already sent in /var/www/html/admin/scripts/pi-hole/php/auth.php on line 93

Signed-off-by: Michael Epstein <mepstein@mediabox.cl>
2019-01-16 01:51:54 -03:00
DL6ER
a10f23b79a Prevent multiple static DHCP entries for the same IP address to get added. Fixes #889
Signed-off-by: DL6ER <dl6er@dl6er.de>
2019-01-15 17:17:34 +01:00
Sylvia van Os
525901e552 Read DNS server list from file
Signed-off-by: Sylvia van Os <sylvia@hackerchick.me>
2019-01-13 19:49:49 +01:00