Quiet excessive warnings.

app/src/main/java/org/thoughtcrime/securesms/mediasend/v2/MediaSelectionActivity.kt

@@ -3,7 +3,6 @@ package org.thoughtcrime.securesms.mediasend.v2
 import android.animation.ValueAnimator
 import android.content.Context
 import android.content.Intent
-import android.content.pm.ActivityInfo
 import android.graphics.Color
 import android.os.Bundle
 import android.view.KeyEvent
@@ -17,15 +16,17 @@ import androidx.constraintlayout.widget.ConstraintSet
 import androidx.core.content.ContextCompat
 import androidx.core.view.updateLayoutParams
 import androidx.lifecycle.ViewModelProvider
-import androidx.navigation.Navigation
+import androidx.navigation.findNavController
 import androidx.navigation.fragment.NavHostFragment
 import androidx.transition.AutoTransition
 import androidx.transition.TransitionManager
 import com.google.android.material.animation.ArgbEvaluatorCompat
 import org.signal.core.util.BreakIteratorCompat
+import org.signal.core.util.OVERRIDE_TRANSITION_CLOSE_COMPAT
 import org.signal.core.util.getParcelableArrayListExtraCompat
 import org.signal.core.util.getParcelableExtraCompat
 import org.signal.core.util.logging.Log
+import org.signal.core.util.overrideActivityTransitionCompat
 import org.thoughtcrime.securesms.PassphraseRequiredActivity
 import org.thoughtcrime.securesms.R
 import org.thoughtcrime.securesms.components.emoji.EmojiEventListener
@@ -91,10 +92,6 @@ class MediaSelectionActivity :
   override fun onCreate(savedInstanceState: Bundle?, ready: Boolean) {
     setContentView(R.layout.media_selection_activity)
 
-    if (false) {
-      requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED
-    }
-
     FullscreenHelper.showSystemUI(window)
     WindowUtil.setNavigationBarColor(this, 0x01000000)
     WindowUtil.setStatusBarColor(window, Color.TRANSPARENT)
@@ -252,7 +249,7 @@ class MediaSelectionActivity :
     )
 
     finish()
-    overridePendingTransition(R.anim.stationary, R.anim.camera_slide_to_bottom)
+    overrideActivityTransitionCompat(OVERRIDE_TRANSITION_CLOSE_COMPAT, R.anim.stationary, R.anim.camera_slide_to_bottom)
   }
 
   override fun onSentWithoutResult() {
@@ -260,7 +257,7 @@ class MediaSelectionActivity :
     setResult(RESULT_OK, intent)
 
     finish()
-    overridePendingTransition(R.anim.stationary, R.anim.camera_slide_to_bottom)
+    overrideActivityTransitionCompat(OVERRIDE_TRANSITION_CLOSE_COMPAT, R.anim.stationary, R.anim.camera_slide_to_bottom)
   }
 
   override fun onSendError(error: Throwable) {
@@ -276,7 +273,7 @@ class MediaSelectionActivity :
       Log.w(TAG, "Failed to send message.", error)
 
       finish()
-      overridePendingTransition(R.anim.stationary, R.anim.camera_slide_to_bottom)
+      overrideActivityTransitionCompat(OVERRIDE_TRANSITION_CLOSE_COMPAT, R.anim.stationary, R.anim.camera_slide_to_bottom)
     }
   }
 
@@ -285,7 +282,7 @@ class MediaSelectionActivity :
 
     setResult(RESULT_CANCELED)
     finish()
-    overridePendingTransition(R.anim.stationary, R.anim.camera_slide_to_bottom)
+    overrideActivityTransitionCompat(OVERRIDE_TRANSITION_CLOSE_COMPAT, R.anim.stationary, R.anim.camera_slide_to_bottom)
   }
 
   override fun onPopFromReview() {
@@ -336,7 +333,7 @@ class MediaSelectionActivity :
 
   private inner class OnBackPressed : OnBackPressedCallback(true) {
     override fun handleOnBackPressed() {
-      val navController = Navigation.findNavController(this@MediaSelectionActivity, R.id.fragment_container)
+      val navController = this@MediaSelectionActivity.findNavController(R.id.fragment_container)
 
       if (shareToTextStory && navController.currentDestination?.id == R.id.textStoryPostCreationFragment) {
         finish()

app/src/main/java/org/thoughtcrime/securesms/profiles/manage/EditProfileFragment.kt

@@ -1,3 +1,5 @@
+@file:Suppress("DEPRECATION")
+
 package org.thoughtcrime.securesms.profiles.manage
 
 import android.content.DialogInterface
@@ -20,6 +22,7 @@ import com.bumptech.glide.Glide
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.google.android.material.snackbar.Snackbar
 import org.signal.core.util.concurrent.LifecycleDisposable
+import org.signal.core.util.getParcelableCompat
 import org.thoughtcrime.securesms.AvatarPreviewActivity
 import org.thoughtcrime.securesms.LoggingFragment
 import org.thoughtcrime.securesms.R
@@ -57,7 +60,9 @@ class EditProfileFragment : LoggingFragment() {
   private lateinit var binding: EditProfileFragmentBinding
   private lateinit var disposables: LifecycleDisposable
 
-  private val DISABLED_ALPHA = 0.4f
+  companion object {
+    private const val DISABLED_ALPHA = 0.4f
+  }
 
   override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
     binding = EditProfileFragmentBinding.inflate(inflater, container, false)
@@ -128,7 +133,7 @@ class EditProfileFragment : LoggingFragment() {
       } else if (bundle.getBoolean(AvatarPickerFragment.SELECT_AVATAR_CLEAR)) {
         viewModel.onAvatarSelected(requireContext(), null)
       } else {
-        val result = bundle.getParcelable<Media>(AvatarPickerFragment.SELECT_AVATAR_MEDIA)
+        val result = bundle.getParcelableCompat(AvatarPickerFragment.SELECT_AVATAR_MEDIA, Media::class.java)
         viewModel.onAvatarSelected(requireContext(), result)
       }
     }

app/src/main/java/org/thoughtcrime/securesms/registration/viewmodel/SvrAuthCredentialSet.kt

@@ -6,6 +6,7 @@
 package org.thoughtcrime.securesms.registration.viewmodel
 
 import android.os.Parcelable
+import kotlinx.parcelize.IgnoredOnParcel
 import kotlinx.parcelize.Parcelize
 import org.whispersystems.signalservice.api.svr.Svr3Credentials
 import org.whispersystems.signalservice.internal.push.AuthCredentials
@@ -23,7 +24,10 @@ data class SvrAuthCredentialSet(
     ParcelableSvr3AuthCredentials.createOrNull(svr3Credentials)
   )
 
+  @IgnoredOnParcel
   val svr2: AuthCredentials? = svr2Credentials?.credentials()
+
+  @IgnoredOnParcel
   val svr3: Svr3Credentials? = svr3Credentials?.credentials()
 
   @Parcelize

app/src/main/java/org/thoughtcrime/securesms/service/webrtc/AndroidTelecomUtil.kt

@@ -161,6 +161,7 @@ object AndroidTelecomUtil {
     return true
   }
 
+  @Suppress("DEPRECATION")
   fun selectAudioDevice(recipientId: RecipientId, device: SignalAudioManager.AudioDevice) {
     if (telecomSupported) {
       val connection: AndroidCallConnection? = connections[recipientId]
@@ -176,6 +177,7 @@ object AndroidTelecomUtil {
     }
   }
 
+  @Suppress("DEPRECATION")
   fun getSelectedAudioDevice(recipientId: RecipientId): SignalAudioManager.AudioDevice {
     if (telecomSupported) {
       val connection: AndroidCallConnection? = connections[recipientId]
@@ -199,6 +201,7 @@ object AndroidTelecomUtil {
   }
 }
 
+@Suppress("DEPRECATION")
 @RequiresApi(26)
 private fun Connection.setAudioRouteIfDifferent(newRoute: Int) {
   if (callAudioState.route != newRoute) {