Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-28 12:44:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Detect priority-related unsatisfiable dependencies in jobs.

Browse Source
This commit is contained in:
Greyson Parrelli
2025-08-14 16:56:10 -04:00
parent 939dcc9295
commit 0ed4785935
2 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/src/main/java/org/thoughtcrime/securesms/jobs/FastJobStorage.kt
View File

@@ -486,11 +486,12 @@ class FastJobStorage(private val jobDatabase: JobDatabase) : JobStorage {
/**
* Note that this is currently only checking a specific kind of circular dependency -- ones that are
* created between dependencies and queues.
* created between dependencies, queues, and priorities.
*
* More specifically, dependencies where one job depends on another job in the same queue that was
* scheduled *after* it. These dependencies will never resolve. Under normal circumstances these
* won't occur, but *could* occur if the user changed their clock (either purposefully or automatically).
* scheduled *after* it, or if it depends on a job with a lower priority. These dependencies will
* never resolve. Under normal circumstances these won't occur, but *could* occur if the user changed
* their clock (either purposefully or automatically).
*
* Rather than go through and delete them from the database, removing them from memory at load time
* serves the same effect and doesn't require new write methods. This should also be very rare.
@@ -511,7 +512,7 @@ class FastJobStorage(private val jobDatabase: JobDatabase) : JobStorage {
return false
}
return dependsOnJob.createTime > job.createTime
return dependsOnJob.createTime > job.createTime || dependsOnJob.globalPriority < job.globalPriority || dependsOnJob.queuePriority < job.queuePriority
}
/**