From 13e0b8dec09fe654756de2b6edc9bf3c830fe529 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Mon, 22 Nov 2021 17:58:55 -0500 Subject: [PATCH] Fix issue with recycling mute icon in conversation list. --- .../securesms/components/FromTextView.java | 12 +++--------- .../conversationlist/ConversationListItem.java | 2 +- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/FromTextView.java b/app/src/main/java/org/thoughtcrime/securesms/components/FromTextView.java index ae013da007..b6899d11c2 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/FromTextView.java +++ b/app/src/main/java/org/thoughtcrime/securesms/components/FromTextView.java @@ -5,14 +5,10 @@ import android.graphics.PorterDuff; import android.graphics.PorterDuffColorFilter; import android.graphics.Typeface; import android.graphics.drawable.Drawable; -import android.os.Build; import android.text.Spannable; import android.text.SpannableString; import android.text.SpannableStringBuilder; import android.text.style.CharacterStyle; -import android.text.style.MetricAffectingSpan; -import android.text.style.StyleSpan; -import android.text.style.TypefaceSpan; import android.util.AttributeSet; import androidx.annotation.Nullable; @@ -20,7 +16,6 @@ import androidx.core.content.ContextCompat; import org.signal.core.util.logging.Log; import org.thoughtcrime.securesms.R; -import org.thoughtcrime.securesms.components.emoji.EmojiTextView; import org.thoughtcrime.securesms.components.emoji.SimpleEmojiTextView; import org.thoughtcrime.securesms.recipients.Recipient; import org.thoughtcrime.securesms.util.SpanUtil; @@ -32,9 +27,6 @@ public class FromTextView extends SimpleEmojiTextView { private static final String TAG = Log.tag(FromTextView.class); - private final static Typeface BOLD_TYPEFACE = Typeface.create("sans-serif-medium", Typeface.NORMAL); - private final static Typeface LIGHT_TYPEFACE = Typeface.create("sans-serif", Typeface.NORMAL); - public FromTextView(Context context) { super(context); } @@ -52,8 +44,10 @@ public class FromTextView extends SimpleEmojiTextView { } public void setText(Recipient recipient, boolean read, @Nullable String suffix) { - String fromString = recipient.getDisplayName(getContext()); + setText(recipient, recipient.getDisplayName(getContext()), read, suffix); + } + public void setText(Recipient recipient, @Nullable CharSequence fromString, boolean read, @Nullable String suffix) { SpannableStringBuilder builder = new SpannableStringBuilder(); SpannableString fromSpan = new SpannableString(fromString); fromSpan.setSpan(getFontSpan(!read), 0, fromSpan.length(), Spannable.SPAN_INCLUSIVE_EXCLUSIVE); diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversationlist/ConversationListItem.java b/app/src/main/java/org/thoughtcrime/securesms/conversationlist/ConversationListItem.java index 38c56128a2..ce665478c8 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversationlist/ConversationListItem.java +++ b/app/src/main/java/org/thoughtcrime/securesms/conversationlist/ConversationListItem.java @@ -192,7 +192,7 @@ public final class ConversationListItem extends ConstraintLayout if (highlightSubstring != null) { String name = recipient.get().isSelf() ? getContext().getString(R.string.note_to_self) : recipient.get().getDisplayName(getContext()); - this.fromView.setText(SearchUtil.getHighlightedSpan(locale, SpanUtil::getMediumBoldSpan, name, highlightSubstring, SearchUtil.MATCH_ALL)); + this.fromView.setText(recipient.get(), SearchUtil.getHighlightedSpan(locale, SpanUtil::getMediumBoldSpan, name, highlightSubstring, SearchUtil.MATCH_ALL), false, null); } else { this.fromView.setText(recipient.get(), false); }