Refactor FeatureFlags.

This commit is contained in:
Greyson Parrelli
2024-06-12 13:57:07 -04:00
parent 39cb1c638e
commit 13f7a64139
76 changed files with 1059 additions and 1053 deletions

View File

@@ -36,7 +36,7 @@ class MessageBackupListener : PersistentAlarmManagerListener() {
@JvmStatic
fun schedule(context: Context?) {
if (FeatureFlags.messageBackups() && SignalStore.backup().areBackupsEnabled) {
if (FeatureFlags.messageBackups && SignalStore.backup().areBackupsEnabled) {
MessageBackupListener().onReceive(context, getScheduleIntent())
}
}

View File

@@ -192,7 +192,7 @@ object AndroidTelecomUtil {
}
private fun isTelecomAllowedForDevice(): Boolean {
if (FeatureFlags.internalUser()) {
if (FeatureFlags.internalUser) {
return !SignalStore.internalValues().callingDisableTelecom()
}
return RingRtcDynamicConfiguration.isTelecomAllowedForDevice()

View File

@@ -22,19 +22,19 @@ object RingRtcDynamicConfiguration {
return when {
isHardwareBlocklisted() || isKnownFaultyHardwareImplementation() -> AudioProcessingMethod.ForceSoftwareAec3
isSoftwareBlocklisted() -> AudioProcessingMethod.ForceHardware
Build.VERSION.SDK_INT < 29 && FeatureFlags.useHardwareAecIfOlderThanApi29() -> AudioProcessingMethod.ForceHardware
Build.VERSION.SDK_INT < 29 && FeatureFlags.useHardwareAecIfOlderThanApi29 -> AudioProcessingMethod.ForceHardware
Build.VERSION.SDK_INT < 29 -> AudioProcessingMethod.ForceSoftwareAec3
else -> AudioProcessingMethod.ForceHardware
}
}
fun isTelecomAllowedForDevice(): Boolean {
return FeatureFlags.telecomManufacturerAllowList().lowercase().asListContains(Build.MANUFACTURER.lowercase()) &&
!FeatureFlags.telecomModelBlockList().lowercase().asListContains(Build.MODEL.lowercase())
return FeatureFlags.telecomManufacturerAllowList.lowercase().asListContains(Build.MANUFACTURER.lowercase()) &&
!FeatureFlags.telecomModelBlocklist.lowercase().asListContains(Build.MODEL.lowercase())
}
private fun isHardwareBlocklisted(): Boolean {
return FeatureFlags.hardwareAecBlocklistModels().asListContains(Build.MODEL)
return FeatureFlags.hardwareAecBlocklistModels.asListContains(Build.MODEL)
}
fun isKnownFaultyHardwareImplementation(): Boolean {
@@ -44,6 +44,6 @@ object RingRtcDynamicConfiguration {
}
private fun isSoftwareBlocklisted(): Boolean {
return FeatureFlags.softwareAecBlocklistModels().asListContains(Build.MODEL)
return FeatureFlags.softwareAecBlocklistModels.asListContains(Build.MODEL)
}
}