Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2025-12-23 04:28:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Separate message for media decode failure.

Browse Source
This commit is contained in:
Nicholas
2022-12-16 15:32:59 -05:00
committed by GitHub
parent 0d8f6de4c1
commit 16668574a9
4 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/org/thoughtcrime/securesms/mediapreview/MediaPreviewFragment.java
View File

@@ -96,6 +96,7 @@ public abstract class MediaPreviewFragment extends Fragment {
public interface Events { public interface Events {
boolean singleTapOnMedia(); boolean singleTapOnMedia();
void onMediaNotAvailable(); void onMediaNotAvailable();
void unableToPlayMedia();
void onMediaReady(); void onMediaReady();
void onPlaying(); void onPlaying();
void onStopped(); void onStopped();

5
app/src/main/java/org/thoughtcrime/securesms/mediapreview/MediaPreviewV2Fragment.kt
View File

@@ -436,6 +436,11 @@ class MediaPreviewV2Fragment : Fragment(R.layout.fragment_media_preview_v2), Med
debouncer.clear() debouncer.clear()
} }
override fun unableToPlayMedia() {
Toast.makeText(requireContext(), R.string.MediaPreviewActivity_unable_to_play_media, Toast.LENGTH_LONG).show()
requireActivity().finish()
}
private fun forward(mediaItem: MediaTable.MediaRecord) { private fun forward(mediaItem: MediaTable.MediaRecord) {
val attachment = mediaItem.attachment val attachment = mediaItem.attachment
val uri = attachment?.uri val uri = attachment?.uri

2
app/src/main/java/org/thoughtcrime/securesms/mediapreview/VideoMediaPreviewFragment.java
View File

@@ -84,7 +84,7 @@ public final class VideoMediaPreviewFragment extends MediaPreviewFragment {
@Override @Override
public void onError() { public void onError() {
events.onMediaNotAvailable(); events.unableToPlayMedia();
} }
}); });

2
app/src/main/res/values/strings.xml
View File

@@ -1988,6 +1988,8 @@
<!-- All media preview title when viewing media sent by another recipient to you (allows changing of \'You\' based on context) --> <!-- All media preview title when viewing media sent by another recipient to you (allows changing of \'You\' based on context) -->
<string name="MediaPreviewActivity_s_to_you">%1$s to you</string> <string name="MediaPreviewActivity_s_to_you">%1$s to you</string>
<string name="MediaPreviewActivity_media_no_longer_available">Media no longer available.</string> <string name="MediaPreviewActivity_media_no_longer_available">Media no longer available.</string>
<!-- Notifying the user that the device has encountered a technical issue and is unable to render a video. -->
<string name="MediaPreviewActivity_unable_to_play_media">Unable to play media.</string>
<string name="MediaPreviewActivity_error_finding_message">Error finding message.</string> <string name="MediaPreviewActivity_error_finding_message">Error finding message.</string>
<string name="MediaPreviewActivity_cant_find_an_app_able_to_share_this_media">Can\'t find an app able to share this media.</string> <string name="MediaPreviewActivity_cant_find_an_app_able_to_share_this_media">Can\'t find an app able to share this media.</string>
<string name="MediaPreviewActivity_dismiss_due_to_error">Close</string> <string name="MediaPreviewActivity_dismiss_due_to_error">Close</string>