From 184e0bc3c20cf9bb5f5030f2b07e5c3d73a21d2f Mon Sep 17 00:00:00 2001 From: dweep Date: Tue, 7 Jul 2026 14:11:31 +0530 Subject: [PATCH] Fix black bars around circular notification avatars Uses the app's own square contact_photo_target_size dimension for the Glide submit() call instead of the OEM-overridable system dimensions android.R.dimen.notification_large_icon_width/height. Those system dimensions aren't guaranteed to be square, so CircleCrop() could produce a rectangular bitmap with transparent letterbox padding, which some OEM skins render as black bars instead of transparency. Fixes #14811 Closes signalapp/Signal-Android#14867 --- .../securesms/notifications/v2/NotificationExtensions.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/notifications/v2/NotificationExtensions.kt b/app/src/main/java/org/thoughtcrime/securesms/notifications/v2/NotificationExtensions.kt index d81c9b8c12..e06728f2cb 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/notifications/v2/NotificationExtensions.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/notifications/v2/NotificationExtensions.kt @@ -49,8 +49,8 @@ fun Recipient.getContactDrawable(context: Context): Drawable? { .diskCacheStrategy(DiskCacheStrategy.ALL) .transform(MultiTransformation(listOf(CircleCrop()))) .submit( - context.resources.getDimensionPixelSize(android.R.dimen.notification_large_icon_width), - context.resources.getDimensionPixelSize(android.R.dimen.notification_large_icon_height) + context.resources.getDimensionPixelSize(R.dimen.contact_photo_target_size), + context.resources.getDimensionPixelSize(R.dimen.contact_photo_target_size) ) .get(IMAGE_LOAD_TIMEOUT_SECONDS, TimeUnit.SECONDS) } catch (e: InterruptedException) {