Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-19 08:09:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use sqlite-jdbc for unit tests to enable FTS5 and JSON1 support.

Browse Source
This commit is contained in:
Greyson Parrelli
2026-03-23 13:04:33 -04:00
committed by Cody Henthorne
parent c3b8768570
commit 2bb9578ef9
9 changed files with 939 additions and 592 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
app/src/test/java/org/thoughtcrime/securesms/testutil/SignalDatabaseMigrationRule.kt
View File

@@ -5,13 +5,11 @@
package org.thoughtcrime.securesms.testutil
import androidx.sqlite.db.SupportSQLiteDatabase
import androidx.sqlite.db.SupportSQLiteOpenHelper
import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory
import androidx.test.core.app.ApplicationProvider
import org.junit.rules.ExternalResource
import org.thoughtcrime.securesms.database.SQLiteDatabase
import org.thoughtcrime.securesms.database.helpers.SignalDatabaseMigrations
import org.thoughtcrime.securesms.testing.JdbcSqliteDatabase
import org.thoughtcrime.securesms.testing.TestSignalSQLiteDatabase
class SignalDatabaseMigrationRule(private val upgradedVersion: Int = 286) : ExternalResource() {
@@ -40,25 +38,14 @@ class SignalDatabaseMigrationRule(private val upgradedVersion: Int = 286) : Exte
companion object {
/**
* Create an in-memory only database of a snapshot of V286. This includes
* all non-FTS tables, indexes, and triggers.
* Create an in-memory only database of a snapshot of V286. Uses sqlite-jdbc (org.xerial) to
* provide a modern SQLite with FTS5 and JSON1 support. This includes all non-FTS tables,
* indexes, and triggers.
*/
private fun inMemoryUpgradedDatabase(): SQLiteDatabase {
val configuration = SupportSQLiteOpenHelper.Configuration(
context = ApplicationProvider.getApplicationContext(),
name = "snapshot",
callback = object : SupportSQLiteOpenHelper.Callback(286) {
override fun onCreate(db: SupportSQLiteDatabase) {
SNAPSHOT_V286.forEach { db.execSQL(it.sql) }
}
override fun onUpgrade(db: SupportSQLiteDatabase, oldVersion: Int, newVersion: Int) = Unit
},
useNoBackupDirectory = false,
allowDataLossOnRecovery = true
)
val helper = FrameworkSQLiteOpenHelperFactory().create(configuration)
return TestSignalSQLiteDatabase(helper.writableDatabase)
val db = JdbcSqliteDatabase.createInMemory()
SNAPSHOT_V286.forEach { db.execSQL(it.sql) }
return TestSignalSQLiteDatabase(db)
}
private val SNAPSHOT_V286 = listOf(

27
app/src/test/java/org/thoughtcrime/securesms/testutil/SignalDatabaseRule.kt
View File

@@ -5,16 +5,15 @@
package org.thoughtcrime.securesms.testutil
import androidx.sqlite.db.SupportSQLiteDatabase
import androidx.sqlite.db.SupportSQLiteOpenHelper
import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory
import androidx.test.core.app.ApplicationProvider
import io.mockk.every
import io.mockk.mockkObject
import io.mockk.unmockkObject
import org.junit.rules.ExternalResource
import org.thoughtcrime.securesms.database.SQLiteDatabase
import org.thoughtcrime.securesms.database.SearchTable
import org.thoughtcrime.securesms.database.SignalDatabase
import org.thoughtcrime.securesms.testing.JdbcSqliteDatabase
import org.thoughtcrime.securesms.testing.TestSignalDatabase
class SignalDatabaseRule : ExternalResource() {
@@ -41,24 +40,16 @@ class SignalDatabaseRule : ExternalResource() {
companion object {
/**
* Create an in-memory only database mimicking one created fresh for Signal. This includes
* all non-FTS tables, indexes, and triggers.
* Create an in-memory only database mimicking one created fresh for Signal. Uses sqlite-jdbc
* (org.xerial) to provide a modern SQLite with FTS5 and JSON1 support, bypassing Robolectric's
* limited native SQLite.
*/
private fun inMemorySignalDatabase(): TestSignalDatabase {
val configuration = SupportSQLiteOpenHelper.Configuration(
context = ApplicationProvider.getApplicationContext(),
name = "test",
callback = object : SupportSQLiteOpenHelper.Callback(1) {
override fun onCreate(db: SupportSQLiteDatabase) = Unit
override fun onUpgrade(db: SupportSQLiteDatabase, oldVersion: Int, newVersion: Int) = Unit
},
useNoBackupDirectory = false,
allowDataLossOnRecovery = true
)
val helper = FrameworkSQLiteOpenHelperFactory().create(configuration)
val signalDatabase = TestSignalDatabase(ApplicationProvider.getApplicationContext(), helper)
val db = JdbcSqliteDatabase.createInMemory()
val signalDatabase = TestSignalDatabase(ApplicationProvider.getApplicationContext(), db, db)
signalDatabase.onCreateTablesIndexesAndTriggers(signalDatabase.signalWritableDatabase)
SearchTable.CREATE_TABLE.forEach { signalDatabase.signalWritableDatabase.execSQL(it) }
SearchTable.CREATE_TRIGGERS.forEach { signalDatabase.signalWritableDatabase.execSQL(it) }
return signalDatabase
}