From 2d5492ffac4dc71c9e26bf1257a3bcd78db478fb Mon Sep 17 00:00:00 2001 From: Alex Hart Date: Tue, 3 Aug 2021 09:57:44 -0300 Subject: [PATCH] Add accessibility descriptions to voice note player view. Fixes #11518 --- .../securesms/components/voice/VoiceNotePlayerView.kt | 7 +++++++ app/src/main/res/layout/voice_note_player_view.xml | 3 +++ app/src/main/res/values/strings.xml | 6 ++++++ 3 files changed, 16 insertions(+) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/voice/VoiceNotePlayerView.kt b/app/src/main/java/org/thoughtcrime/securesms/components/voice/VoiceNotePlayerView.kt index ec2251a26a..b59f909453 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/voice/VoiceNotePlayerView.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/components/voice/VoiceNotePlayerView.kt @@ -99,6 +99,7 @@ class VoiceNotePlayerView @JvmOverloads constructor( background.colorFilter = SimpleColorFilter(ContextCompat.getColor(context, R.color.voice_note_player_view_background)) } + contentDescription = context.getString(R.string.VoiceNotePlayerView__navigate_to_voice_message) setOnClickListener { lastState?.let { listener?.onNavigateToMessage(it.threadId, it.threadRecipientId, it.senderId, it.messageTimestamp, it.messagePositionInThread) @@ -171,6 +172,12 @@ class VoiceNotePlayerView @JvmOverloads constructor( } lottieDirection = direction + playPauseToggleView.contentDescription = if (direction == TO_PLAY) { + context.getString(R.string.VoiceNotePlayerView__play_voice_message) + } else { + context.getString(R.string.VoiceNotePlayerView__pause_voice_message) + } + playPauseToggleView.pauseAnimation() playPauseToggleView.speed = (direction * 2).toFloat() playPauseToggleView.resumeAnimation() diff --git a/app/src/main/res/layout/voice_note_player_view.xml b/app/src/main/res/layout/voice_note_player_view.xml index 46c3d2f97a..08c5ac8ae8 100644 --- a/app/src/main/res/layout/voice_note_player_view.xml +++ b/app/src/main/res/layout/voice_note_player_view.xml @@ -9,6 +9,7 @@ android:layout_width="36dp" android:layout_height="0dp" android:layout_marginStart="6dp" + android:contentDescription="@string/VoiceNotePlayerView__pause_voice_message" android:padding="10dp" app:layout_constraintBottom_toBottomOf="@id/voice_note_player_info" app:layout_constraintStart_toStartOf="parent" @@ -43,6 +44,7 @@ android:layout_height="36dp" android:layout_marginEnd="8dp" android:background="?selectableItemBackground" + android:contentDescription="@string/VoiceNotePlayerView__change_voice_message_speed" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@id/voice_note_player_close" app:layout_constraintTop_toTopOf="parent"> @@ -69,6 +71,7 @@ android:layout_width="36dp" android:layout_height="36dp" android:layout_marginEnd="4dp" + android:contentDescription="@string/VoiceNotePlayerView__stop_voice_message" android:scaleType="centerInside" app:layout_constraintBottom_toBottomOf="@id/voice_note_player_info" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 62d173cb26..334e73abae 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -3646,6 +3646,12 @@ %1$s ยท %2$s + Stop voice message + Change voice message speed + Pause voice message + Play voice message + Navigate to voice message + Avatar preview