Fix issues with StorageSyncV2 bookkeeping.

1. I screwed up the comparators in the record processor. Pretty bad, glad this was caught.
2. Previously I was sort of keeping track of which local-only records were accounted for while I was merging, and then hoping everything worked out in the end. Now I just very directly take some set differences and retrieve the appropriate records, so it's clear that we should never fail certain validations.
3. Rev's the feature flag so we don't turn on something broken.
This commit is contained in:
Greyson Parrelli
2021-04-13 11:32:24 -04:00
committed by GitHub
parent fb316a22c6
commit 35c102aa98
14 changed files with 81 additions and 40 deletions

View File

@@ -74,7 +74,7 @@ public final class FeatureFlags {
private static final String ANIMATED_STICKER_MIN_TOTAL_MEMORY = "android.animatedStickerMinTotalMemory";
private static final String MESSAGE_PROCESSOR_ALARM_INTERVAL = "android.messageProcessor.alarmIntervalMins";
private static final String MESSAGE_PROCESSOR_DELAY = "android.messageProcessor.foregroundDelayMs";
private static final String STORAGE_SYNC_V2 = "android.storageSyncV2";
private static final String STORAGE_SYNC_V2 = "android.storageSyncV2.2";
/**
* We will only store remote values for flags in this set. If you want a flag to be controllable