Improve payment withdrawals.

2026-04-24 10:51:27 +01:00 · 2022-03-04 12:14:42 -05:00
parent eae6a971e6
commit 427e73f7fd
7 changed files with 232 additions and 63 deletions
--- a/app/src/test/java/org/thoughtcrime/securesms/keyvalue/PaymentsValuesTest.kt
+++ b/app/src/test/java/org/thoughtcrime/securesms/keyvalue/PaymentsValuesTest.kt
@@ -0,0 +1,158 @@
+package org.thoughtcrime.securesms.keyvalue
+
+import android.app.Application
+import androidx.test.core.app.ApplicationProvider
+import org.junit.Assert.assertEquals
+import org.junit.Before
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.powermock.api.mockito.PowerMockito
+import org.powermock.core.classloader.annotations.PowerMockIgnore
+import org.powermock.core.classloader.annotations.PrepareForTest
+import org.powermock.modules.junit4.rule.PowerMockRule
+import org.robolectric.RobolectricTestRunner
+import org.robolectric.annotation.Config
+import org.thoughtcrime.securesms.dependencies.ApplicationDependencies
+import org.thoughtcrime.securesms.dependencies.MockApplicationDependencyProvider
+import org.thoughtcrime.securesms.util.FeatureFlags
+
+@RunWith(RobolectricTestRunner::class)
+@Config(manifest = Config.NONE, application = Application::class)
+@PowerMockIgnore("org.mockito.*", "org.robolectric.*", "android.*", "androidx.*", "org.powermock.*")
+@PrepareForTest(FeatureFlags::class)
+class PaymentsValuesTest {
+
+  @get:Rule
+  val powerMockRule = PowerMockRule()
+
+  @Before
+  fun setup() {
+    if (!ApplicationDependencies.isInitialized()) {
+      ApplicationDependencies.init(ApplicationProvider.getApplicationContext(), MockApplicationDependencyProvider())
+    }
+
+    PowerMockito.mockStatic(FeatureFlags::class.java)
+  }
+
+  @Test
+  fun `when unregistered, expect NOT_IN_REGION`() {
+    setupStore(
+      KeyValueDataSet().apply {
+        putBoolean(AccountValues.KEY_IS_REGISTERED, false)
+      }
+    )
+
+    assertEquals(PaymentsAvailability.NOT_IN_REGION, SignalStore.paymentsValues().paymentsAvailability)
+  }
+
+  @Test
+  fun `when flag disabled and no account, expect DISABLED_REMOTELY`() {
+    setupStore(
+      KeyValueDataSet().apply {
+        putBoolean(AccountValues.KEY_IS_REGISTERED, true)
+        putString(AccountValues.KEY_E164, "+15551234567")
+        putBoolean(PaymentsValues.MOB_PAYMENTS_ENABLED, false)
+      }
+    )
+
+    PowerMockito.`when`(FeatureFlags.payments()).thenReturn(false)
+    PowerMockito.`when`(FeatureFlags.paymentsCountryBlocklist()).thenReturn("")
+
+    assertEquals(PaymentsAvailability.DISABLED_REMOTELY, SignalStore.paymentsValues().paymentsAvailability)
+  }
+
+  @Test
+  fun `when flag disabled but has account, expect WITHDRAW_ONLY`() {
+    setupStore(
+      KeyValueDataSet().apply {
+        putBoolean(AccountValues.KEY_IS_REGISTERED, true)
+        putString(AccountValues.KEY_E164, "+15551234567")
+        putBoolean(PaymentsValues.MOB_PAYMENTS_ENABLED, true)
+      }
+    )
+
+    PowerMockito.`when`(FeatureFlags.payments()).thenReturn(false)
+    PowerMockito.`when`(FeatureFlags.paymentsCountryBlocklist()).thenReturn("")
+
+    assertEquals(PaymentsAvailability.WITHDRAW_ONLY, SignalStore.paymentsValues().paymentsAvailability)
+  }
+
+  @Test
+  fun `when flag enabled and no account, expect REGISTRATION_AVAILABLE`() {
+    setupStore(
+      KeyValueDataSet().apply {
+        putBoolean(AccountValues.KEY_IS_REGISTERED, true)
+        putString(AccountValues.KEY_E164, "+15551234567")
+        putBoolean(PaymentsValues.MOB_PAYMENTS_ENABLED, false)
+      }
+    )
+
+    PowerMockito.`when`(FeatureFlags.payments()).thenReturn(true)
+    PowerMockito.`when`(FeatureFlags.paymentsCountryBlocklist()).thenReturn("")
+
+    assertEquals(PaymentsAvailability.REGISTRATION_AVAILABLE, SignalStore.paymentsValues().paymentsAvailability)
+  }
+
+  @Test
+  fun `when flag enabled and has account, expect WITHDRAW_AND_SEND`() {
+    setupStore(
+      KeyValueDataSet().apply {
+        putBoolean(AccountValues.KEY_IS_REGISTERED, true)
+        putString(AccountValues.KEY_E164, "+15551234567")
+        putBoolean(PaymentsValues.MOB_PAYMENTS_ENABLED, true)
+      }
+    )
+
+    PowerMockito.`when`(FeatureFlags.payments()).thenReturn(true)
+    PowerMockito.`when`(FeatureFlags.paymentsCountryBlocklist()).thenReturn("")
+
+    assertEquals(PaymentsAvailability.WITHDRAW_AND_SEND, SignalStore.paymentsValues().paymentsAvailability)
+  }
+
+  @Test
+  fun `when flag enabled and no account and in the country blocklist, expect NOT_IN_REGION`() {
+    setupStore(
+      KeyValueDataSet().apply {
+        putBoolean(AccountValues.KEY_IS_REGISTERED, true)
+        putString(AccountValues.KEY_E164, "+15551234567")
+        putBoolean(PaymentsValues.MOB_PAYMENTS_ENABLED, false)
+      }
+    )
+
+    PowerMockito.`when`(FeatureFlags.payments()).thenReturn(true)
+    PowerMockito.`when`(FeatureFlags.paymentsCountryBlocklist()).thenReturn("1")
+
+    assertEquals(PaymentsAvailability.NOT_IN_REGION, SignalStore.paymentsValues().paymentsAvailability)
+  }
+
+  @Test
+  fun `when flag enabled and has account and in the country blocklist, expect WITHDRAW_ONLY`() {
+    setupStore(
+      KeyValueDataSet().apply {
+        putBoolean(AccountValues.KEY_IS_REGISTERED, true)
+        putString(AccountValues.KEY_E164, "+15551234567")
+        putBoolean(PaymentsValues.MOB_PAYMENTS_ENABLED, true)
+      }
+    )
+
+    PowerMockito.`when`(FeatureFlags.payments()).thenReturn(true)
+    PowerMockito.`when`(FeatureFlags.paymentsCountryBlocklist()).thenReturn("1")
+
+    assertEquals(PaymentsAvailability.WITHDRAW_ONLY, SignalStore.paymentsValues().paymentsAvailability)
+  }
+
+  /**
+   * Account values will overwrite some values upon first access, so this takes care of that
+   */
+  private fun setupStore(dataset: KeyValueDataSet) {
+    val store = KeyValueStore(
+      MockKeyValuePersistentStorage.withDataSet(
+        dataset.apply {
+          putString(AccountValues.KEY_ACI, "")
+        }
+      )
+    )
+    SignalStore.inject(store)
+  }
+}