From 4354a9ff5e067abb0d4f076d8768bd6594039ab0 Mon Sep 17 00:00:00 2001 From: Nicholas Tinsley Date: Fri, 23 Aug 2024 16:18:11 -0400 Subject: [PATCH] Add small logging to attachment finalization process. --- .../securesms/components/ThumbnailView.java | 19 +++++++++++++++++-- .../securesms/database/AttachmentTable.kt | 2 ++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/ThumbnailView.java b/app/src/main/java/org/thoughtcrime/securesms/components/ThumbnailView.java index 53ae540541..54870bf298 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/ThumbnailView.java +++ b/app/src/main/java/org/thoughtcrime/securesms/components/ThumbnailView.java @@ -38,6 +38,8 @@ import org.signal.core.util.concurrent.SettableFuture; import org.signal.core.util.logging.Log; import org.signal.glide.transforms.SignalDownsampleStrategy; import org.thoughtcrime.securesms.R; +import org.thoughtcrime.securesms.attachments.Attachment; +import org.thoughtcrime.securesms.attachments.DatabaseAttachment; import org.thoughtcrime.securesms.blurhash.BlurHash; import org.thoughtcrime.securesms.components.transfercontrols.TransferControlView; import org.thoughtcrime.securesms.database.AttachmentTable; @@ -404,9 +406,22 @@ public class ThumbnailView extends FrameLayout { return new SettableFuture<>(false); } - Log.i(TAG, "loading part with id " + slide.asAttachment().getUri() + Attachment slideAttachment = slide.asAttachment(); + String id; + if (slideAttachment instanceof DatabaseAttachment) { + id = ((DatabaseAttachment) slideAttachment).attachmentId.serialize(); + } else { + final Uri uri = slideAttachment.getUri(); + if (uri != null) { + id = slideAttachment.getUri().toString(); + } else { + id = slideAttachment.getClass().getSimpleName(); + } + } + + Log.i(TAG, "loading part with id " + id + ", progress " + slide.getTransferState() + ", fast preflight id: " + - slide.asAttachment().fastPreflightId); + slideAttachment.fastPreflightId); BlurHash previousBlurHash = this.slide != null ? this.slide.getPlaceholderBlur() : null; diff --git a/app/src/main/java/org/thoughtcrime/securesms/database/AttachmentTable.kt b/app/src/main/java/org/thoughtcrime/securesms/database/AttachmentTable.kt index 626e0ad9df..ecfb35378f 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/database/AttachmentTable.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/database/AttachmentTable.kt @@ -947,6 +947,8 @@ class AttachmentTable( .where("$ID = ?", attachmentId.id) .run() + Log.i(TAG, "[finalizeAttachmentAfterDownload] Finalized downloaded data for $attachmentId. (MessageId: $mmsId, $attachmentId)") + hashMatch != null }