Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-02-25 20:23:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make ACI's optional on ContactRecords.

Browse Source
This commit is contained in:
Greyson Parrelli
2023-08-17 14:33:18 -04:00
committed by GitHub
parent 2492b8de34
commit 4b6b87d632
5 changed files with 61 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/src/test/java/org/thoughtcrime/securesms/storage/ContactRecordProcessorTest.kt
View File

@@ -69,7 +69,7 @@ class ContactRecordProcessorTest {
}
@Test
fun `isInvalid, missing serviceId, true`() {
fun `isInvalid, missing ACI and PNI, true`() {
// GIVEN
val subject = ContactRecordProcessor(ACI_A, PNI_A, E164_A, recipientTable)
@@ -84,6 +84,24 @@ class ContactRecordProcessorTest {
assertTrue(result)
}
@Test
fun `isInvalid, unknown ACI and PNI, true`() {
// GIVEN
val subject = ContactRecordProcessor(ACI_A, PNI_A, E164_A, recipientTable)
val record = buildRecord {
setAci(ACI.UNKNOWN.toString())
setPni(PNI.UNKNOWN.toString())
setE164(E164_B)
}
// WHEN
val result = subject.isInvalid(record)
// THEN
assertTrue(result)
}
@Test
fun `isInvalid, e164 matches self, true`() {
// GIVEN