From 56378c716656be9c861989dfe64b78824ee4572d Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Thu, 25 Jun 2026 09:55:34 -0400 Subject: [PATCH] Make lower hand suggestions available for external users. --- .../components/settings/app/labs/LabsSettingsEvents.kt | 1 - .../components/settings/app/labs/LabsSettingsFragment.kt | 9 --------- .../components/settings/app/labs/LabsSettingsState.kt | 1 - .../settings/app/labs/LabsSettingsViewModel.kt | 6 ------ .../org/thoughtcrime/securesms/keyvalue/LabsValues.kt | 3 --- .../service/webrtc/GroupConnectedActionProcessor.java | 4 ---- 6 files changed, 24 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsEvents.kt b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsEvents.kt index 355d528679..10d1398aa2 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsEvents.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsEvents.kt @@ -10,6 +10,5 @@ sealed interface LabsSettingsEvents { data class ToggleStoryArchive(val enabled: Boolean) : LabsSettingsEvents data class ToggleIncognito(val enabled: Boolean) : LabsSettingsEvents data class ToggleBetterSearch(val enabled: Boolean) : LabsSettingsEvents - data class ToggleAutoLowerHand(val enabled: Boolean) : LabsSettingsEvents data class ToggleStarredMessages(val enabled: Boolean) : LabsSettingsEvents } diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsFragment.kt b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsFragment.kt index e68d950901..3731a6d68a 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsFragment.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsFragment.kt @@ -125,15 +125,6 @@ private fun LabsSettingsContent( ) } - item { - Rows.ToggleRow( - checked = state.autoLowerHand, - text = "Auto Lower Hand Suggestion", - label = "Show a prompt to lower your raised hand when you are speaking in a group call.", - onCheckChanged = { onEvent(LabsSettingsEvents.ToggleAutoLowerHand(it)) } - ) - } - item { Rows.ToggleRow( checked = state.starredMessages, diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsState.kt b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsState.kt index 195389d998..977530347f 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsState.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsState.kt @@ -13,6 +13,5 @@ data class LabsSettingsState( val storyArchive: Boolean = false, val incognito: Boolean = false, val betterSearch: Boolean = false, - val autoLowerHand: Boolean = false, val starredMessages: Boolean = false ) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsViewModel.kt b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsViewModel.kt index 18add3164f..9cb6c7db43 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsViewModel.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/components/settings/app/labs/LabsSettingsViewModel.kt @@ -33,11 +33,6 @@ class LabsSettingsViewModel : ViewModel() { SignalStore.labs.betterSearch = event.enabled _state.value = _state.value.copy(betterSearch = event.enabled) } - is LabsSettingsEvents.ToggleAutoLowerHand -> { - SignalStore.labs.autoLowerHand = event.enabled - _state.value = _state.value.copy(autoLowerHand = event.enabled) - } - is LabsSettingsEvents.ToggleStarredMessages -> { SignalStore.labs.starredMessages = event.enabled _state.value = _state.value.copy(starredMessages = event.enabled) @@ -51,7 +46,6 @@ class LabsSettingsViewModel : ViewModel() { storyArchive = SignalStore.labs.storyArchive, incognito = SignalStore.labs.incognito, betterSearch = SignalStore.labs.betterSearch, - autoLowerHand = SignalStore.labs.autoLowerHand, starredMessages = SignalStore.labs.starredMessages ) } diff --git a/app/src/main/java/org/thoughtcrime/securesms/keyvalue/LabsValues.kt b/app/src/main/java/org/thoughtcrime/securesms/keyvalue/LabsValues.kt index 5cce588892..d12dc0a97e 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/keyvalue/LabsValues.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/keyvalue/LabsValues.kt @@ -8,7 +8,6 @@ class LabsValues internal constructor(store: KeyValueStore) : SignalStoreValues( const val STORY_ARCHIVE: String = "labs.story_archive" const val INCOGNITO: String = "labs.incognito" const val BETTER_SEARCH: String = "labs.better_search" - const val AUTO_LOWER_HAND: String = "labs.auto_lower_hand" const val STARRED_MESSAGES: String = "labs.starred_messages" } @@ -24,8 +23,6 @@ class LabsValues internal constructor(store: KeyValueStore) : SignalStoreValues( var betterSearch by booleanValue(BETTER_SEARCH, true).falseForExternalUsers() - var autoLowerHand by booleanValue(AUTO_LOWER_HAND, true).falseForExternalUsers() - var starredMessages by booleanValue(STARRED_MESSAGES, true).falseForExternalUsers() private fun SignalStoreValueDelegate.falseForExternalUsers(): SignalStoreValueDelegate { diff --git a/app/src/main/java/org/thoughtcrime/securesms/service/webrtc/GroupConnectedActionProcessor.java b/app/src/main/java/org/thoughtcrime/securesms/service/webrtc/GroupConnectedActionProcessor.java index 16e760e71c..8909ace46f 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/service/webrtc/GroupConnectedActionProcessor.java +++ b/app/src/main/java/org/thoughtcrime/securesms/service/webrtc/GroupConnectedActionProcessor.java @@ -473,10 +473,6 @@ public class GroupConnectedActionProcessor extends GroupActionProcessor { protected @NonNull WebRtcServiceState handleGroupCallSpeechEvent(@NonNull WebRtcServiceState currentState, @NonNull GroupCall.SpeechEvent speechEvent) { Log.i(tag, "handleGroupCallSpeechEvent :: " + speechEvent.name()); - if (!SignalStore.labs().getAutoLowerHand()) { - return currentState; - } - return currentState.builder() .changeCallInfoState() .setGroupCallSpeechEvent(new GroupCallSpeechEvent(speechEvent))