From 631b428a84c9d090bc01c56142dbf8606a2cbd7f Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Wed, 22 Mar 2023 17:13:04 -0400 Subject: [PATCH] Fix log statement. We were printing out the envelope deviceId, which isn't populated with sealed sender and was always 0. Should have used the one from the decryption result. --- .../securesms/messages/MessageDecryptor.kt | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/messages/MessageDecryptor.kt b/app/src/main/java/org/thoughtcrime/securesms/messages/MessageDecryptor.kt index 7de4b7c6d8..c7d94cc836 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/messages/MessageDecryptor.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/messages/MessageDecryptor.kt @@ -57,7 +57,6 @@ import org.whispersystems.signalservice.api.push.SignalServiceAddress import org.whispersystems.signalservice.internal.push.SignalServiceProtos.Content import org.whispersystems.signalservice.internal.push.SignalServiceProtos.Envelope import org.whispersystems.signalservice.internal.push.SignalServiceProtos.PniSignatureMessage -import org.whispersystems.signalservice.internal.push.UnsupportedDataMessageException import java.util.Optional /** @@ -339,7 +338,7 @@ object MessageDecryptor { } private fun logPrefix(envelope: Envelope, cipherResult: SignalServiceCipherResult): String { - return logPrefix(envelope.timestamp, cipherResult.metadata.sourceServiceId.toString(), envelope.sourceDevice) + return logPrefix(envelope.timestamp, cipherResult.metadata.sourceServiceId.toString(), cipherResult.metadata.sourceDeviceId) } private fun logPrefix(envelope: Envelope, exception: ProtocolException): String { @@ -350,14 +349,6 @@ object MessageDecryptor { } } - private fun logPrefix(envelope: Envelope, exception: UnsupportedDataMessageException): String { - return if (exception.sender != null) { - logPrefix(envelope.timestamp, exception.sender, exception.senderDevice) - } else { - logPrefix(envelope.timestamp, envelope.sourceUuid, envelope.sourceDevice) - } - } - private fun logPrefix(timestamp: Long, sender: String?, deviceId: Int): String { val senderString = sender ?: "null" return "[$timestamp] $senderString:$deviceId |"