Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-26 03:40:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix non-rendered previews when differ by trailing slash.

Browse Source
This commit is contained in:
Alan Evans
2021-01-05 17:07:18 -04:00
parent 86542febf9
commit 64312f9c7f
4 changed files with 137 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

89
app/src/test/java/org/thoughtcrime/securesms/linkpreview/LinkPreviewUtilTest_findValidPreviewUrls.java Normal file
View File

@@ -0,0 +1,89 @@
package org.thoughtcrime.securesms.linkpreview;
import android.app.Application;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.annotation.Config;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
@RunWith(RobolectricTestRunner.class)
@Config(manifest = Config.NONE, application = Application.class)
public final class LinkPreviewUtilTest_findValidPreviewUrls {
@Test
public void no_links() {
LinkPreviewUtil.Links links = LinkPreviewUtil.findValidPreviewUrls("No links");
assertEquals(0, links.size());
assertSame(LinkPreviewUtil.Links.EMPTY, links);
}
@Test
public void contains_a_link() {
LinkPreviewUtil.Links links = LinkPreviewUtil.findValidPreviewUrls("https://signal.org");
assertEquals(1, links.size());
assertTrue(links.containsUrl("https://signal.org"));
}
@Test
public void does_not_contain_link() {
LinkPreviewUtil.Links links = LinkPreviewUtil.findValidPreviewUrls("https://signal.org");
assertEquals(1, links.size());
assertFalse(links.containsUrl("https://signal.org/page"));
}
@Test
public void contains_two_links() {
LinkPreviewUtil.Links links = LinkPreviewUtil.findValidPreviewUrls("Links https://signal.org https://android.com");
assertEquals(2, links.size());
assertTrue(links.containsUrl("https://signal.org"));
assertTrue(links.containsUrl("https://android.com"));
}
@Test
public void link_trailing_slash_insensitivity() {
LinkPreviewUtil.Links links = LinkPreviewUtil.findValidPreviewUrls("Links https://signal.org/ https://android.com");
assertEquals(2, links.size());
assertTrue(links.containsUrl("https://signal.org"));
assertTrue(links.containsUrl("https://android.com"));
assertTrue(links.containsUrl("https://signal.org/"));
assertTrue(links.containsUrl("https://android.com/"));
}
@Test
public void link_trailing_slash_insensitivity_where_last_url_has_trailing_slash() {
LinkPreviewUtil.Links links = LinkPreviewUtil.findValidPreviewUrls("Links https://signal.org https://android.com/");
assertEquals(2, links.size());
assertTrue(links.containsUrl("https://signal.org"));
assertTrue(links.containsUrl("https://android.com"));
assertTrue(links.containsUrl("https://signal.org/"));
assertTrue(links.containsUrl("https://android.com/"));
}
@Test
public void multiple_trailing_slashes_are_not_stripped() {
LinkPreviewUtil.Links links = LinkPreviewUtil.findValidPreviewUrls("Link https://android.com/");
assertEquals(1, links.size());
assertTrue(links.containsUrl("https://android.com"));
assertTrue(links.containsUrl("https://android.com/"));
assertFalse(links.containsUrl("https://android.com//"));
}
}