From 6a23896077ea1f0eb5bdda4bb583cdedefd62fb8 Mon Sep 17 00:00:00 2001 From: Cody Henthorne Date: Tue, 9 Jun 2026 16:22:57 -0400 Subject: [PATCH] Fix view state restore crash from LinkPreviewView sharing an id with its ViewStub. --- .../securesms/components/LinkPreviewView.java | 31 +------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/components/LinkPreviewView.java b/app/src/main/java/org/thoughtcrime/securesms/components/LinkPreviewView.java index 827cbb9eab..9d50bd86c2 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/components/LinkPreviewView.java +++ b/app/src/main/java/org/thoughtcrime/securesms/components/LinkPreviewView.java @@ -4,8 +4,6 @@ import android.content.Context; import android.content.res.TypedArray; import android.graphics.Canvas; import android.graphics.Color; -import android.os.Bundle; -import android.os.Parcelable; import android.util.AttributeSet; import android.view.View; import android.view.ViewGroup; @@ -43,9 +41,6 @@ import okhttp3.HttpUrl; */ public class LinkPreviewView extends FrameLayout { - private static final String STATE_ROOT = "linkPreviewView.state.root"; - private static final String STATE_STATE = "linkPreviewView.state.state"; - private static final int TYPE_CONVERSATION = 0; private static final int TYPE_COMPOSE = 1; @@ -114,30 +109,6 @@ public class LinkPreviewView extends FrameLayout { setWillNotDraw(false); } - @Override - protected @NonNull Parcelable onSaveInstanceState() { - Parcelable root = super.onSaveInstanceState(); - Bundle bundle = new Bundle(); - - bundle.putParcelable(STATE_ROOT, root); - bundle.putParcelable(STATE_STATE, thumbnailState); - - return bundle; - } - - @Override - protected void onRestoreInstanceState(Parcelable state) { - if (state instanceof Bundle) { - Parcelable root = ((Bundle) state).getParcelable(STATE_ROOT); - thumbnailState = ((Bundle) state).getParcelable(STATE_STATE); - - thumbnailState.applyState(thumbnail); - super.onRestoreInstanceState(root); - } else { - super.onRestoreInstanceState(state); - } - } - @Override protected void dispatchDraw(Canvas canvas) { super.dispatchDraw(canvas); @@ -251,7 +222,7 @@ public class LinkPreviewView extends FrameLayout { thumbnailState.applyState(thumbnail); } else { cornerMask.setRadii(topStart, topEnd, 0, 0); - thumbnailState.copy( + thumbnailState = thumbnailState.copy( topStart, defaultRadius, defaultRadius,