Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-19 16:19:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Prompt to save PIN to device password manager.

Browse Source 
Fixes an issue where the system auto-fill could overwrite the Signal backup key saved to the device password manager with the Signal PIN. The PIN confirmation screen now explicitly uses `CredentialManager` to save the `Signal PIN` under a separate username from the `Signal Backups` key, allowing both credentials to be stored and auto-filled correctly.

- Add `com.google.android.libraries.identity.googleid` dependency so `CredentialManager` works on Android < 14.
- Prompt to save Signal PIN to credential manager after PIN is created/edited.
This commit is contained in:
jeffrey-signal
2025-07-08 11:53:01 -04:00
committed by Alex Hart
parent ef874c4091
commit 6d58e89c18
11 changed files with 181 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/res/values/strings.xml
View File

@@ -4572,6 +4572,8 @@
<string name="ConfirmKbsPinFragment__pin_created">PIN created.</string>
<string name="ConfirmKbsPinFragment__re_enter_your_pin">Re-enter your PIN</string>
<string name="ConfirmKbsPinFragment__creating_pin">Creating PIN…</string>
<!-- ID used when saving the PIN to the device password manager. -->
<string name="ConfirmKbsPinFragment__pin_password_manager_id">Signal PIN</string>
<!-- KbsSplashFragment -->
<string name="KbsSplashFragment__introducing_pins">Introducing PINs</string>
@@ -8362,6 +8364,8 @@
<string name="MessageBackupsKeyRecordScreen__confirm_save_to_password_manager_title">Save to password manager?</string>
<!-- Dialog message confirming that the user wants to save a backup key to the device password manager. -->
<string name="MessageBackupsKeyRecordScreen__confirm_save_to_password_manager_body">Only store your backup key in a password manager that you trust is secure. Signal does not make a recommendation on which password manager is right for you.</string>
<!-- ID used when saving the backup key to the device password manager. -->
<string name="MessageBackupsKeyRecordScreen__backup_key_password_manager_id">Signal Backups</string>
<!-- Message shown after the backup key is successfully saved to the device password manager. -->
<string name="MessageBackupsKeyRecordScreen__save_to_password_manager_success">Saved to your password manager</string>
<!-- Dialog title shown when there is an error saving the backup key to the device password manager. -->