Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-02-26 20:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix groups not showing after pin restore.

Browse Source
This commit is contained in:
Cody Henthorne
2021-09-17 09:56:49 -04:00
committed by GitHub
parent 62d8c115ba
commit 6f6da699a3
3 changed files with 34 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/src/test/java/org/thoughtcrime/securesms/database/SmsDatabaseTest.kt
View File

@@ -19,7 +19,7 @@ import org.hamcrest.CoreMatchers.`is` as isEqual
@Config(manifest = Config.NONE, application = Application::class)
class SmsDatabaseTest {
private lateinit var writeableDatabase: AndroidSQLiteDatabase
private lateinit var db: AndroidSQLiteDatabase
private lateinit var smsDatabase: SmsDatabase
@Before
@@ -28,13 +28,13 @@ class SmsDatabaseTest {
execSQL(SmsDatabase.CREATE_TABLE)
}
writeableDatabase = sqlCipher.writableDatabase
db = sqlCipher.writableDatabase
smsDatabase = SmsDatabase(ApplicationProvider.getApplicationContext(), sqlCipher)
}
@After
fun tearDown() {
writeableDatabase.close()
db.close()
}
@Test
@@ -44,7 +44,7 @@ class SmsDatabaseTest {
@Test
fun `getThreadIdForMessage when message present for id, return thread id`() {
TestSms.insertSmsMessage(db = writeableDatabase, threadId = 1)
TestSms.insertSmsMessage(db)
assertThat(smsDatabase.getThreadIdForMessage(1), isEqual(1))
}
@@ -55,7 +55,13 @@ class SmsDatabaseTest {
@Test
fun `hasMeaningfulMessage when normal message, return true`() {
TestSms.insertSmsMessage(db = writeableDatabase, threadId = 1)
TestSms.insertSmsMessage(db)
assertTrue(smsDatabase.hasMeaningfulMessage(1))
}
@Test
fun `hasMeaningfulMessage when GV2 create message only, return true`() {
TestSms.insertSmsMessage(db, type = MmsSmsColumns.Types.BASE_INBOX_TYPE or MmsSmsColumns.Types.SECURE_MESSAGE_BIT or MmsSmsColumns.Types.GROUP_V2_BIT or MmsSmsColumns.Types.GROUP_UPDATE_BIT)
assertTrue(smsDatabase.hasMeaningfulMessage(1))
}
@@ -63,16 +69,16 @@ class SmsDatabaseTest {
fun `hasMeaningfulMessage when empty and then with ignored types, always return false`() {
assertFalse(smsDatabase.hasMeaningfulMessage(1))
TestSms.insertSmsMessage(db = writeableDatabase, threadId = 1, type = SmsDatabase.IGNORABLE_TYPESMASK_WHEN_COUNTING)
TestSms.insertSmsMessage(db, type = SmsDatabase.IGNORABLE_TYPESMASK_WHEN_COUNTING)
assertFalse(smsDatabase.hasMeaningfulMessage(1))
TestSms.insertSmsMessage(db = writeableDatabase, threadId = 1, type = MmsSmsColumns.Types.PROFILE_CHANGE_TYPE)
TestSms.insertSmsMessage(db, type = MmsSmsColumns.Types.PROFILE_CHANGE_TYPE)
assertFalse(smsDatabase.hasMeaningfulMessage(1))
TestSms.insertSmsMessage(db = writeableDatabase, threadId = 1, type = MmsSmsColumns.Types.CHANGE_NUMBER_TYPE)
TestSms.insertSmsMessage(db, type = MmsSmsColumns.Types.CHANGE_NUMBER_TYPE)
assertFalse(smsDatabase.hasMeaningfulMessage(1))
TestSms.insertSmsMessage(db = writeableDatabase, threadId = 1, type = MmsSmsColumns.Types.BASE_INBOX_TYPE or MmsSmsColumns.Types.GROUP_V2_LEAVE_BITS)
TestSms.insertSmsMessage(db, type = MmsSmsColumns.Types.BASE_INBOX_TYPE or MmsSmsColumns.Types.GROUP_V2_LEAVE_BITS)
assertFalse(smsDatabase.hasMeaningfulMessage(1))
}
}